You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: keps/sig-node/4540-strict-cpu-reservation/README.md
+9-12Lines changed: 9 additions & 12 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -45,7 +45,7 @@ Items marked with (R) are required *prior to targeting to a milestone / release*
45
45
-[x] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR)
46
46
-[x] (R) KEP approvers have approved the KEP status as `implementable`
47
47
-[x] (R) Design details are appropriately documented
48
-
-[] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors)
48
+
-[x] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors)
49
49
-[x] e2e Tests for all Beta API Operations (endpoints)
50
50
-[x] (R) Ensure GA e2e tests meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
51
51
-[x] (R) Minimum Two Week Window for GA e2e tests to prove flake free
@@ -129,7 +129,7 @@ When `strict-cpu-reservation` is enabled:
129
129
130
130
### Risks and Mitigations
131
131
132
-
The feature is isolated to a specific policy option `strict-cpu-reservation` under `cpuManagerPolicyOptions` and is protected by feature gate `CPUManagerPolicyBetaOptions` before the feature graduates to `Stable` i.e. always enabled.
132
+
The feature is isolated to a specific policy option `strict-cpu-reservation` under `cpuManagerPolicyOptions`.
133
133
134
134
Concern for feature impact on best-effort workloads, the workloads that do not have resource requests, is brought up.
135
135
@@ -313,8 +313,8 @@ No new integration tests for kubelet are planned.
313
313
314
314
#### GA
315
315
316
-
-[] Allow time for feedback (1 year).
317
-
-[] Make sure all risks have been addressed.
316
+
-[X] Allow time for feedback (1 year).
317
+
-[X] Make sure all risks have been addressed.
318
318
319
319
### Upgrade / Downgrade Strategy
320
320
@@ -332,9 +332,6 @@ The `/var/lib/kubelet/cpu_manager_state` needs to be removed when enabling or di
332
332
333
333
###### How can this feature be enabled / disabled in a live cluster?
334
334
335
-
-[X] Feature gate (also fill in values in `kep.yaml`)
- Components depending on the feature gate: `kubelet`
338
335
-[X] Change the kubelet configuration to set a `CPUManager` policy of `static` and a `CPUManager` policy option of `strict-cpu-reservation`
339
336
- Will enabling / disabling the feature require downtime of the control plane? No
340
337
- Will enabling / disabling the feature require downtime or reprovisioning of a node? No -- removing `/var/lib/kubelet/cpu_manager_state` and restarting kubelet are enough.
@@ -346,13 +343,13 @@ Yes. Reserved CPU cores will be strictly used for system daemons and interrupt p
346
343
347
344
The feature is only enabled when all following conditions are met:
348
345
1. The `static``CPUManager` policy is selected
349
-
2. The `CPUManagerPolicyBetaOptions` feature gate is enabled and the `strict-cpu-reservation` policy option is selected
346
+
2. The `strict-cpu-reservation` policy option is selected
350
347
3. The `reservedSystemCPUs` is not empty
351
348
352
349
###### Can the feature be disabled once it has been enabled (i.e. can we roll back the enablement)?
353
350
354
-
Yes, the feature can be disabled by:
355
-
1.Disable feature gate `CPUManagerPolicyBetaOptions` or remove`strict-cpu-reservation` from the list of `CPUManager` policy options
351
+
Yes, the feature can be disabled by the following steps:
352
+
1.Remove`strict-cpu-reservation` from the list of `CPUManager` policy options
356
353
2. Remove `/var/lib/kubelet/cpu_manager_state` and restart kubelet
357
354
358
355
###### What happens if we reenable the feature if it was previously rolled back?
@@ -361,7 +358,7 @@ The feature will be enabled regardless it is enabled for the first time or not.
361
358
362
359
###### Are there any tests for feature enablement/disablement?
363
360
364
-
- A specific e2e test will demonstrate that the default behaviour is preserved when the feature gate is disabled, or when the feature is not used (2 separate tests)
361
+
- A specific e2e test will demonstrate that the default behaviour is preserved when the feature is not used (2 separate tests)
365
362
366
363
### Rollout, Upgrade and Rollback Planning
367
364
@@ -561,7 +558,7 @@ You can safely disable the feature.
0 commit comments