@@ -250,13 +250,15 @@ without any issues.
250
250
251
251
##### Integration tests
252
252
253
- - [ ] ensure existence of healthcheck endpoint (beta requirement)
253
+ - [ X ] ensure existence of healthcheck endpoint (beta requirement)
254
254
255
255
- <test >: <link to test coverage >
256
256
257
257
##### e2e tests
258
258
259
- - [ ] ensure existence of healthcheck endpoint (beta requirement)
259
+ Given this feature is purely in-memory, no enablement/disablement tests are needed.
260
+
261
+ - [ X ] ensure existence of healthcheck endpoint (beta requirement)
260
262
261
263
- <test >: <link to test coverage >
262
264
@@ -345,10 +347,6 @@ We will target this feature behind a flag `ComponentSLIs`
345
347
+ controller-manager
346
348
+ kube-proxy
347
349
348
- ###### Are there any tests for feature enablement/disablement?
349
-
350
- Given this feature is purely in-memory, no enablement/disablement tests are needed.
351
-
352
350
###### Does enabling the feature change any default behavior?
353
351
354
352
Yes it will expose a new metrics endpoint.
@@ -363,7 +361,7 @@ It will expose the metrics endpoint again
363
361
364
362
###### Are there any tests for feature enablement/disablement?
365
363
366
- We intend to add them with our e2e tests.
364
+ Given this feature is purely in-memory, no enablement/disablement tests are needed .
367
365
368
366
### Rollout, Upgrade and Rollback Planning
369
367
@@ -396,7 +394,7 @@ They can check their prometheus scrape configs.
396
394
397
395
###### How can someone using this feature know that it is working for their instance?
398
396
399
- They can curl the apiserver's ` metrics/slis ` endpoint.
397
+ They can curl any of the kubernetes components's (except etcd) ` metrics/slis ` endpoint.
400
398
401
399
###### What are the reasonable SLOs (Service Level Objectives) for the enhancement?
402
400
@@ -466,9 +464,9 @@ details). For now, we leave it here.
466
464
467
465
###### How does this feature react if the API server and/or etcd is unavailable?
468
466
469
- If apiserver is unavailable, then you will not be able to ingest the metrics from the apiserver .
470
- However, the failure of etcd should allow you to scrape the metrics from apiserver, so long as
471
- it is otherwise healthy.
467
+ If component is unavailable, then you will not be able to ingest the metrics from the component .
468
+ However, in the case of the apiserver, the failure of etcd should allow you to scrape the metrics
469
+ from component, so long as it is otherwise healthy.
472
470
473
471
###### What are other known failure modes?
474
472
0 commit comments