Skip to content

Commit 3211347

Browse files
committed
beta3 and GA criterias
Signed-off-by: Itamar Holder <[email protected]>
1 parent a1e930b commit 3211347

File tree

2 files changed

+20
-8
lines changed

2 files changed

+20
-8
lines changed

keps/sig-node/2400-node-swap/README.md

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@
5353
- [Alpha2](#alpha2)
5454
- [Beta 1](#beta-1)
5555
- [Beta 2](#beta-2)
56+
- [Beta 3](#beta-3)
5657
- [GA](#ga)
5758
- [Upgrade / Downgrade Strategy](#upgrade--downgrade-strategy)
5859
- [Version Skew Strategy](#version-skew-strategy)
@@ -858,6 +859,10 @@ For beta 2:
858859

859860
- Add Node-conformance tests for basic swap validation. To avoid disrupting node conformance lanes, only the
860861
cgroup knobs are validated to be defined as expected with no real memory stress or swap use.
862+
863+
For beta 3:
864+
865+
- We want e2e tests that can confirm that eviction will take in account swap usage
861866
- Add a lane dedicated for swap testing, including stress tests and other tests that might be disruptive and intensive.
862867
These lanes are called "swap-conformance", and are (and should remain) consistently green:
863868
- [kubelet-swap-conformance-fedora-serial](https://testgrid.k8s.io/sig-node-kubelet#kubelet-swap-conformance-fedora-serial): Green.
@@ -928,15 +933,22 @@ Here are specific improvements to be made:
928933
- Add e2e test confirming that swap is used for `LimitedSwap`.
929934
- Document [best practices](#best-practices) for setting up Kubernetes with swap
930935

931-
[via cgroups]: #restrict-swap-usage-at-the-cgroup-level
936+
#### Beta 3
932937

933-
#### GA
938+
- Enhance website documentation
939+
- Docs should be close to GA quality before promoting to GA.
940+
- Make eviction manager swap aware.
941+
- Test a wide variety of scenarios that may be affected by swap support, including tests with aggressive memory stress.
942+
- Address memory-backed backed volumes which should not have access to swap.
943+
- Add documentation regarding encrypted swap.
944+
- Test a wide variety of scenarios in which the node is being memory-stressed with different eviction and swap configurations.
945+
Ensure the behavior is consistent and reliable.
946+
- Exclude high-priority, static and mirrored pods from gaining access to swap.
934947

935-
_(Tentative.)_
948+
#### GA
936949

937-
- Test a wide variety of scenarios that may be affected by swap support.
938-
- Remove feature flag.
939-
- Remove the Swap Support using Burstable QoS Pods only deprecated in Beta 2.
950+
- Remove feature gate.
951+
- Ensure swap-conformance tests are continuously green.
940952

941953
### Upgrade / Downgrade Strategy
942954

keps/sig-node/2400-node-swap/kep.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,13 @@ stage: beta
2727
# The most recent milestone for which work toward delivery of this KEP has been
2828
# done. This can be the current (upcoming) milestone, if it is being actively
2929
# worked on.
30-
latest-milestone: "v1.30"
30+
latest-milestone: "v1.33"
3131

3232
# The milestone at which this feature was, or is targeted to be, at each stage.
3333
milestone:
3434
alpha: "v1.22"
3535
beta: "v1.30"
36-
stable: "TBD"
36+
stable: "v1.34"
3737

3838
# The following PRR answers are required at alpha release
3939
# List the feature gate name and the components for which it must be enabled

0 commit comments

Comments
 (0)