Skip to content

Commit 33bac62

Browse files
committed
review feedback
Signed-off-by: Anish Ramasekar <[email protected]>
1 parent 4c79463 commit 33bac62

File tree

2 files changed

+3
-27
lines changed
  • keps/sig-auth/4412-projected-service-account-tokens-for-kubelet-image-credential-providers

2 files changed

+3
-27
lines changed

keps/sig-auth/4412-projected-service-account-tokens-for-kubelet-image-credential-providers/README.md

Lines changed: 2 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -706,7 +706,7 @@ There is an existing e2e test for kubelet credential providers using gcp credent
706706

707707
As part of alpha implementation, the [e2e test has been updated](https://github.com/kubernetes/kubernetes/commit/2090a01e0a495301432276216bbf9af102fc431c) to cover the new credential provider configuration and the new behavior of the kubelet when the `TokenAttributes` field is set.
708708

709-
We created a symlink to the existing gcp credential provider executable with a different name to use for testing service account token for credential provider. The credential provider has been updated to validate the following when plugin is run in service account token mode:\
709+
We created a symlink to the existing gcp credential provider executable with a different name to use for testing service account token for credential provider. The credential provider has been updated to validate the following when plugin is run in service account token mode:
710710

711711
1. Check the required annotations are sent as part of the `CredentialProviderRequest.ServiceAccountAnnotations` field.
712712
2. Check the service account token is sent as part of the `CredentialProviderRequest.ServiceAccountToken` field.
@@ -886,37 +886,13 @@ well as the [existing list] of feature gates.
886886
-->
887887

888888
- [x] Feature gate (also fill in values in `kep.yaml`)
889-
- Feature gate name: `ServiceAccountTokenForKubeletCredentialProviders`
889+
- Feature gate name: `KubeletServiceAccountTokenForCredentialProviders`
890890
- Components depending on the feature gate: kubelet
891891

892-
```go
893-
FeatureSpec{
894-
Default: false,
895-
LockToDefault: false,
896-
PreRelease: featuregate.Alpha,
897-
}
898-
```
899-
900-
```go
901-
FeatureSpec{
902-
Default: true,
903-
LockToDefault: false,
904-
PreRelease: featuregate.Beta,
905-
}
906-
```
907-
908892
- [x] Feature gate (also fill in values in `kep.yaml`)
909893
- Feature gate name: `ServiceAccountNodeAudienceRestriction`
910894
- Components depending on the feature gate: kube-apiserver
911895

912-
```go
913-
FeatureSpec{
914-
Default: true,
915-
LockToDefault: false,
916-
PreRelease: featuregate.Beta,
917-
}
918-
```
919-
920896
###### Does enabling the feature change any default behavior?
921897

922898
<!--

keps/sig-auth/4412-projected-service-account-tokens-for-kubelet-image-credential-providers/kep.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ milestone:
2222
alpha: "v1.33"
2323
beta: "v1.34"
2424
feature-gates:
25-
- name: ServiceAccountTokenForKubeletCredentialProviders
25+
- name: KubeletServiceAccountTokenForCredentialProviders
2626
components:
2727
- kubelet
2828
- name: ServiceAccountNodeAudienceRestriction

0 commit comments

Comments
 (0)