@@ -573,23 +573,10 @@ The policies are respected again.
573573
574574###### Are there any tests for feature enablement/disablement?
575575
576- In the scheduler, this is in-memory feature, so tests checking both feature enabled or disabled were added :
576+ We have tests here :
577577
578- Unit tests:
579-
580- - pkg/api/pod/util_test.go#TestDropNodeInclusionPolicyFields
581- - pkg/scheduler/framework/plugins/podtopologyspread/filtering_test.go#TestPreFilterState
582- - pkg/scheduler/framework/plugins/podtopologyspread/filtering_test.go#TestSingleConstraint
583- - pkg/scheduler/framework/plugins/podtopologyspread/filtering_test.go#TestMultipleConstraints
584- - pkg/scheduler/framework/plugins/podtopologyspread/filtering_test.go#TestPreScoreStateEmptyNodes
585- - pkg/scheduler/framework/plugins/podtopologyspread/filtering_test.go#TestPodTopologySpreadScore
586-
587- Integration tests:
588-
589- - test/integration/scheduler/filters/filters_test.go#TestPodTopologySpreadFilter
590- - test/integration/scheduler/scoring/priorities_test.go#TestPodTopologySpreadScoring
591-
592- However, this KEP also introduces API changes, the tests will be added later, refer to the [ PR] ( https://github.com/kubernetes/kubernetes/pull/112805 ) . I'll update the description once the PR is merged.
578+ - pkg/registry/core/pod/strategy_test.go#TestNodeInclusionPolicyEnablementInCreating
579+ - pkg/registry/core/pod/strategy_test.go#TestNodeInclusionPolicyEnablementInUpdating
593580
594581<!--
595582The e2e framework does not currently support enabling or disabling feature
@@ -636,7 +623,7 @@ Longer term, we may want to require automated upgrade/rollback tests, but we
636623are missing a bunch of machinery and tooling and can't do that now.
637624-->
638625
639- Not yet, but it will be tested manually prior to upgrade following below steps:
626+ Yes, it was tested manually prior to upgrade following below steps, and behaved as expected.
640627
6416281 . Install kubernetes v1.24 cluster with two workloads via installation tools like Kind.
6426292 . Let's name these nodes as node1 and node2, both labelled with key ` kubernetes.io/hostname ` .
@@ -699,7 +686,7 @@ Not yet, but it will be tested manually prior to upgrade following below steps:
699686 - maxSkew: 1
700687 topologyKey: kubernetes.io/hostname
701688 whenUnsatisfiable: DoNotSchedule
702- NodeTaintsPolicy : Honor
689+ nodeTaintsPolicy : Honor
703690 labelSelector:
704691 matchLabels:
705692 foo: bar
0 commit comments