Skip to content

Commit 3406b97

Browse files
committed
KEP-1287: Add missing monitoring PRR question
1 parent 1cb4e89 commit 3406b97

File tree

1 file changed

+10
-1
lines changed
  • keps/sig-node/1287-in-place-update-pod-resources

1 file changed

+10
-1
lines changed

keps/sig-node/1287-in-place-update-pod-resources/README.md

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1287,6 +1287,15 @@ _This section must be completed when targeting beta graduation to a release._
12871287

12881288
Metric: `apiserver_request_total{resource=pods,subresource=resize}`
12891289

1290+
* **How can someone using this feature know that it is working for their instance?**
1291+
1292+
- If the Kubelet supports InPlacePodVerticalScaling, it will always set the `Resources` field in
1293+
container status.
1294+
- The `ResizeStatus` in the pod status should converge to the empty value, indicating the resize has completed.
1295+
- The `Resources` in the container status should converge to the resized resources, or an
1296+
approximation of it (see [Edge-triggered Resizes](#edge-triggered-resizes) for more details on
1297+
when these resources can diverge).
1298+
12901299
* **What are the SLIs (Service Level Indicators) an operator can use to determine
12911300
the health of the service?**
12921301
- [x] Metrics
@@ -1306,7 +1315,7 @@ the health of the service?**
13061315
* **Are there any missing metrics that would be useful to have to improve observability
13071316
of this feature?**
13081317

1309-
- Kubelet admission rejections: https://github.com/kubernetes/kubernetes/issues/125375
1318+
- ~~Kubelet admission rejections: https://github.com/kubernetes/kubernetes/issues/125375~~ (DONE)
13101319
- Resize operate duration (time from the Kubelet seeing the request to actuating the changes): this would require persisting more state about when the resize was first observed.
13111320

13121321
### Dependencies

0 commit comments

Comments
 (0)