Skip to content

Commit 3b445f0

Browse files
committed
Address review comments
1 parent 6051e2c commit 3b445f0

File tree

1 file changed

+15
-12
lines changed
  • keps/sig-storage/3476-volume-group-snapshot

1 file changed

+15
-12
lines changed

keps/sig-storage/3476-volume-group-snapshot/README.md

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -803,18 +803,21 @@ _This section must be completed when targeting beta graduation to a release._
803803
This has a grpc_status_code that shows the operation status. A grpc_status_code
804804
of "OK" indicates the operation is successful, otherwise, it is a failure.
805805

806-
* **How can someone using this feature know that it is working for their instance?
807-
* Events
808-
* Event Reason: A GroupSnapshotCreated Normal Event with a message:
809-
GroupSnapshot <name> was successfully created by the CSI driver.
810-
* API .status
811-
* Condition name:
812-
* Other field: VolumeGroupSnapshot Status has CreationTime != nil and
813-
ReadyToUse = true.
814-
* Other (treat as last resort)
815-
* Details:
816-
817-
* **What are the reasonable SLOs (Service Level Objectives) for the enhancement?
806+
* **How can someone using this feature know that it is working for their instance?**
807+
* Events
808+
* Event Reason: A GroupSnapshotCreated Normal Event with a message:
809+
GroupSnapshot <name> was successfully created by the CSI driver.
810+
* API .status
811+
* Condition name:
812+
* Other field: VolumeGroupSnapshot Status has CreationTime != nil and
813+
ReadyToUse = true.
814+
* Other (treat as last resort)
815+
* Details:
816+
Metric `snapshot_controller_operation_total_seconds` for the
817+
snapshot-controller and the metric `csi_sidecar_operations_seconds` for
818+
the csi-snapshotter sidecar.
819+
820+
* **What are the reasonable SLOs (Service Level Objectives) for the enhancement?**
818821
<!--
819822
At a high level, this usually will be in the form of "high percentile of SLI
820823
per day <= X". It's impossible to provide comprehensive guidance, but at the very

0 commit comments

Comments
 (0)