Skip to content

Commit 41633a8

Browse files
marquizhaircommander
authored andcommitted
KEP-4033: address review feedback
- fix typos - drop mention of deprecating kubelet --cgroup-driver flag - mention "crictl info" as a way to determine if feature is supported by the runtime - add a comment in the cri api proto that the config here is for "global" configuration options
1 parent 6b7c9a8 commit 41633a8

File tree

1 file changed

+9
-7
lines changed
  • keps/sig-node/4033-group-driver-detection-over-cri

1 file changed

+9
-7
lines changed

keps/sig-node/4033-group-driver-detection-over-cri/README.md

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ The responsibility of managing the Linux cgroups is currently split between the
167167
kubelet and the container runtime. Kubelet takes care of the pod (sandbox)
168168
level cgroups whereas the runtime is responsible for per-container cgroups.
169169
There currently are two different low-level management interfaces for cgroups:
170-
maninpulating the cgroupfs directly or using the systemd system management
170+
manipulating the cgroupfs directly or using the systemd system management
171171
daemon to manage them. Currently, both the kubelet and the container runtime
172172
has a configuration setting for selecting the cgroup driver (cgroupfs or
173173
systemd). These settings must be in sync, both kubelet and the runtime
@@ -230,7 +230,8 @@ used.
230230
message RuntimeStatus {
231231
// List of current observed runtime conditions.
232232
repeated RuntimeCondition conditions = 1;
233-
+ // Configuration settings of the runtime
233+
+ // Configuration settings of the runtime. This field contains global
234+
+ // runtime configuration options that are not specific to runtime handlers.
234235
+ RuntimeConfiguration configuration = 2;
235236
}
236237

@@ -264,9 +265,7 @@ will take precedence over cgroupDriver setting from the kubelet config (or
264265
`--cgroup-driver` command line flag). If the runtime does not provide
265266
information about the cgroup driver, then kubelet will fall back to using its
266267
own configuration (`cgroupDriver` from kubeletConfig or the `--cgroup-driver`
267-
flag). Further, the kubeletConfig field and `--cgroup-driver` flag will be
268-
marked as deprecated, to be dropped when the runtimes the Kubelet is supported
269-
to run with all support the flag.
268+
flag).
270269

271270
Kubelet startup is modified so that connection to the CRI server (container
272271
runtime) is established and RuntimeStatus is queried before initializing the
@@ -622,7 +621,10 @@ checking if there are objects with field X set) may be a last resort. Avoid
622621
logs or events for this purpose.
623622
-->
624623

625-
Kubelet and container runtime version.
624+
Kubelet and container runtime version. The
625+
[`crictl`](https://kubernetes.io/docs/tasks/debug/debug-cluster/crictl/) tool
626+
can be used to determine if the container runtime supports the feature (`crictl
627+
info`).
626628

627629
###### How can someone using this feature know that it is working for their instance?
628630

@@ -839,7 +841,7 @@ For each of them, fill in the following information by copying the below templat
839841
- Testing: Are there any tests for failure mode? If not, describe why.
840842
-->
841843

842-
Same that exist today: Kubelet and the CRI server (container runtime) not
844+
Same that exists today: Kubelet and the CRI server (container runtime) not
843845
agreeing on the CgroupDriver while one of them doesn’t support the feature.
844846

845847
###### What steps should be taken if SLOs are not being met to determine the problem?

0 commit comments

Comments
 (0)