Skip to content

Commit 420ef20

Browse files
committed
address comments
Signed-off-by: Rita Zhang <[email protected]>
1 parent 49db474 commit 420ef20

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

keps/sig-auth/5018-dra-adminaccess/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -466,7 +466,7 @@ ResourceClaimTemplate and ResourceClaim for admin access
466466
467467
- Gather feedback
468468
- Additional tests are in Testgrid and linked in KEP
469-
- Implementations in the kubernetes-sigs/dra-example-driver: https://github.com/kubernetes-sigs/dra-example-driver/issues/97 and the NVIDIA dra driver: https://github.com/NVIDIA/k8s-dra-driver-gpu/issues/337
469+
- Implementations in the kubernetes-sigs/dra-example-driver: https://github.com/kubernetes-sigs/dra-example-driver/issues/97
470470
471471
#### GA
472472
@@ -542,7 +542,7 @@ will rollout across nodes.
542542
-->
543543

544544
- kube-controller-manager: If the kube-controller-manager fails to create `ResourceClaim` objects from `ResourceClaimTemplate` due to misconfigurations or permission issues relating to `adminAccess`, then the associated Pods will remain in a pending state and won't be scheduled.
545-
- kube-scheduler: Bugs in the scheduler might lead to Pods not being scheduled even when resources are available or, scheduling Pods that shouldn't be scheduled due to unmet `adminAccess` requirements. If the `DRAAdminAccess` feature gate isn't enabled or is misconfigured, the scheduler might not recognize ResourceClaim requirements, leading to scheduling failures.
545+
- kube-scheduler: Bugs in the scheduler might lead to Pods not being scheduled even when resources are available or, scheduling Pods that shouldn't be scheduled due to unmet `adminAccess` requirements, all this should be part of the generic scheduler backoff behavior. It will not affect running workloads.
546546
- Workloads Without `ResourceClaims` will remain unaffected as the adminAccess feature doesn't interact with them. The new code paths introduced for adminAccess only engage when `ResourceClaims` are present in the Pod specification.
547547
- New Pods requiring `ResourceClaims` with `adminAccess` might remain unscheduled if the control plane components fail to process the claims correctly.
548548
- Existing Pods continue to run unaffected since `ResourceClaim` and `ResourceClaimTemplate`'s spec is immutable, including the adminAccess field, cannot be altered.
@@ -603,7 +603,7 @@ checking if there are objects with field X set) may be a last resort. Avoid
603603
logs or events for this purpose.
604604
-->
605605

606-
".status.allocation.devices.results[*].adminaccess" will be set to true for a claim using adminAccess when needed by a pod.
606+
".status.allocation.devices.results[*].adminAccess" will be set to true for a claim using adminAccess when needed by a pod.
607607

608608
Metrics in kube-controller-manager about total (resourceclaim_controller_resource_claims_adminaccess) and allocated ResourceClaims with adminAccess (resourceclaim_controller_allocated_resource_claims_adminaccess).
609609

@@ -718,7 +718,7 @@ and creating new ones, as well as about cluster-level services (e.g. DNS):
718718
-->
719719

720720
- The DynamicResourceAllocation feature gate must be enabled to create ResourceClaim, ResourceClaimTemplate. More details at [KEP-4381 - DRA Structured Parameters](https://github.com/kubernetes/enhancements/issues/4381)
721-
- A third-party DRA driver is required for how the driver should interpret the AdminAcess field to get acess to device specific resources without allocating them.
721+
- A third-party DRA driver is required for how the driver should interpret the AdminAccess field to get acess to device specific resources without allocating them.
722722

723723
### Scalability
724724

0 commit comments

Comments
 (0)