Skip to content

Commit 448f855

Browse files
committed
Add review from SergeyKanzhelev
Signed-off-by: Sascha Grunert <[email protected]>
1 parent 37837bf commit 448f855

File tree

1 file changed

+10
-0
lines changed
  • keps/sig-node/4639-oci-volume-source

1 file changed

+10
-0
lines changed

keps/sig-node/4639-oci-volume-source/README.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1160,6 +1160,16 @@ An out-of-tree CSI plugin can provide flexibility and modularity, but there are
11601160
- Supporting the image pull secrets as well as credentials provider will be tricky and needs to be reimplemented with the separate API calls.
11611161
- External CSI plugins implement their own lifecycle management and garbage collection mechanisms,
11621162
yet these already exist in-tree for OCI images.
1163+
- The kubelet has max parallel image pull constant to maintain the reasonable
1164+
load on a disk and network. This will not be respected by CSI driver and
1165+
the only point of integration may be if we move this constant down to
1166+
runtime.
1167+
- The kubelet has GC logic that is not cleaning up images immediately in
1168+
case they will be reused. Also GC logic has it's own thresholds and
1169+
behavior on eviction. It will be nice to have those integrated.
1170+
- The kubelet exposes metrics on image pulls and we have KEP in place to
1171+
improve it even further. Having CSI exposing those metrics will require
1172+
customer to integrate with one more source of data.
11631173
- Performance: There is additional overhead with an out-of-tree CSI plugin, especially in scenarios requiring frequent image pulls
11641174
or large volumes of data.
11651175

0 commit comments

Comments
 (0)