Skip to content

Commit 541c292

Browse files
authored
Merge pull request #3809 from xuzhenglun/master
KEP-3668: update to implementable
2 parents 74cc885 + 3380b63 commit 541c292

File tree

3 files changed

+18
-6
lines changed

3 files changed

+18
-6
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
kep-number: 3070
1+
kep-number: 3668
22
alpha:
33
approver: "@wojtek-t"

keps/sig-network/3668-reserved-service-nodeport-range/README.md

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,10 @@
1414
- [Current Services NodePort allocation model](#current-services-nodeport-allocation-model)
1515
- [Proposed Services NodePorts allocation model](#proposed-services-nodeports-allocation-model)
1616
- [Test Plan](#test-plan)
17+
- [Prerequisite testing updates](#prerequisite-testing-updates)
1718
- [Unit tests](#unit-tests)
19+
- [Integration tests](#integration-tests)
20+
- [e2e tests](#e2e-tests)
1821
- [Graduation Criteria](#graduation-criteria)
1922
- [Alpha](#alpha)
2023
- [Beta](#beta)
@@ -273,17 +276,21 @@ Example 3 Small service nodeport range:
273276
274277
### Test Plan
275278
276-
This feature doesn't modify the cluster behavior, only the order on which dynamic port are assigned to NodePort Services,
277-
there is no need for e2e or integration tests, unit tests are enough.
278-
279279
[x] I/we understand the owners of the involved components may require updates to
280280
existing tests to make this code solid enough prior to committing the changes necessary
281281
to implement this enhancement.
282282
283+
##### Prerequisite testing updates
284+
None
283285
284286
##### Unit tests
287+
- `kubernetes/pkg/registry/core/service/portallocator`: `12/10/2022` - `83.1`
288+
289+
##### Integration tests
285290
286-
- pkg/registry/core/service/portallocator/allocator_test.go - 83.1
291+
This feature doesn't modify the cluster behavior, only the order on which dynamic port are assigned to NodePort Services, there is no need for e2e or integration tests, unit tests are enough.
292+
293+
##### e2e tests
287294
288295
### Graduation Criteria
289296
@@ -438,6 +445,11 @@ No
438445
###### Will enabling / using this feature result in non-negligible increase of resource usage (CPU, RAM, disk, IO, ...) in any components?
439446
440447
No
448+
449+
###### Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)?
450+
451+
No
452+
441453
### Troubleshooting
442454
443455
###### How does this feature react if the API server and/or etcd is unavailable?

keps/sig-network/3668-reserved-service-nodeport-range/kep.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ authors:
44
- "@xuzhenglun"
55
owning-sig: sig-network
66
participating-sigs:
7-
status: provisional
7+
status: implementable
88
creation-date: 2022-11-30
99
reviewers:
1010
approvers:

0 commit comments

Comments
 (0)