Skip to content

Commit 56298f4

Browse files
committed
Address comments
1 parent 16e81ea commit 56298f4

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

keps/sig-storage/2268-non-graceful-shutdown/README.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -408,11 +408,12 @@ Pick one more of these and delete the rest.
408408
-->
409409
- [X] Metrics
410410
- Metric name:
411-
- We added new metrics `deleting_pods_total`, `deleting_pods_error_total`
412-
in Pod GC Controller.
413-
For Attach Detach Controller, there's already a metric:
414-
`attachdetach_controller_forced_detaches`
415-
There is also a `kube_node_spec_taint` in [kube-state-metrics](https://github.com/kubernetes/kube-state-metrics/blob/main/docs/node-metrics.md) that is a metric for the taint of a Kubernetes cluster node.
411+
- New metrics are added in Pod GC Controller:
412+
- `force_delete_pods_total`, the number of pods that are being forcefully deleted since the Pod GC Controller started.
413+
- `force_delete_pod_errors_total`, the number of errors encountered when forcefully deleting the pods since the Pod GC Controller started.
414+
- For Attach Detach Controller, there's already a metric:
415+
- `attachdetach_controller_forced_detaches`, the number of times the Attach Detach Controller performed a forced detach.
416+
- There is also a `kube_node_spec_taint` in [kube-state-metrics](https://github.com/kubernetes/kube-state-metrics/blob/main/docs/node-metrics.md) that is a metric for the taint of a Kubernetes cluster node.
416417
- [Optional] Aggregation method:
417418
- Components exposing the metric:
418419
- [X] Other (treat as last resort)
@@ -685,6 +686,7 @@ For each of them, fill in the following information by copying the below templat
685686
- 2021-12-03: Removed `SafeDetach` flag. Requires a user to add the `out-of-service` taint when he/she knows the node is shutdown.
686687
- Kubernetes v1.24: moved to alpha.
687688
- Kubernete v1.26: moved to beta.
689+
- Kubernete v1.28: moved to stable.
688690

689691
## Alternatives
690692

keps/sig-storage/2268-non-graceful-shutdown/kep.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,5 +43,5 @@ disable-supported: true
4343

4444
# The following PRR answers are required at beta release
4545
metrics:
46-
- deleting_pods_total
47-
- deleting_pods_error_total
46+
- force_delete_pods_total
47+
- force_delete_pod_errors_total

0 commit comments

Comments
 (0)