Skip to content

Commit 564a00b

Browse files
committed
Address comments
1 parent d68d08d commit 564a00b

File tree

1 file changed

+3
-1
lines changed
  • keps/sig-storage/3476-volume-group-snapshot

1 file changed

+3
-1
lines changed

keps/sig-storage/3476-volume-group-snapshot/README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ Note: In the following, we will use VolumeGroupSnapshot Controller to refer to t
136136
* This will trigger the VolumeGroupSnapshot controller to create a VolumeGroupSnapshotContent API object, and also call the CreateVolumeGroupSnapshot CSI function.
137137
* The controller will retrieve all volumeSnapshotHandles in the Volume Group Snapshot from the CSI CreateVolumeGroupSnapshotResponse, create VolumeSnapshotContents pointing to the volumeSnapshotHandles. Then the controller will create VolumeSnapshots pointing to the VolumeSnapshotContents.
138138
* CreateVolumeGroupSnapshot CSI function response
139-
* The CreateVolumeGroupSnapshot CSI function should return a list of snapshots (Snapshot message defined in CSI Spec) in its response. The VolumeGroupSnapshot controller can use the returned list of snapshots to construct corresponding individual VolumeSnapshotContents and VolumeSnapshots, wait for VolumeSnapshots and VolumeSnapshotContents to be bound, and update SnapshotList in the VolumeGroupSnapshot Status and SnapshotContentList in the VolumeGroupSnapshotContent Status.
139+
* The CreateVolumeGroupSnapshot CSI function should return a list of snapshots (Snapshot message defined in CSI Spec) in its response. The VolumeGroupSnapshot controller can use the returned list of snapshots to construct corresponding individual VolumeSnapshotContents and VolumeSnapshots, wait for VolumeSnapshots and VolumeSnapshotContents to be bound, and update SnapshotRefList in the VolumeGroupSnapshot Status and SnapshotContentList in the VolumeGroupSnapshotContent Status.
140140
* Individual VolumeSnapshots will be named in this format:
141141
* <snap>-<hash of VolumeGroupSnapshot UUID+PVC UUID+timestamp>
142142
* A label with VolumeGroupSnapshot name will also be added to the VolumeSnapshot
@@ -146,6 +146,8 @@ apiVersion: snapshot.storage.k8s.io/v1
146146
kind: VolumeSnapshot
147147
metadata:
148148
name: snapshot1
149+
labels:
150+
volumeGroupSnapshotName: groupSnapshot1
149151
spec:
150152
source:
151153
persistentVolumeClaimName: vsc1

0 commit comments

Comments
 (0)