Skip to content

Commit 5917ac0

Browse files
committed
DRA: add reminder about required vs. optional DeviceClassName
1 parent b9ea723 commit 5917ac0

File tree

1 file changed

+14
-0
lines changed
  • keps/sig-node/4381-dra-structured-parameters

1 file changed

+14
-0
lines changed

keps/sig-node/4381-dra-structured-parameters/README.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1267,6 +1267,20 @@ type RequestDetail struct {
12671267
// +optional
12681268
AdminAccess *bool
12691269
}
1270+
```
1271+
1272+
```
1273+
<<[UNRESOLVED @johnbelamaric ]>>
1274+
1275+
There is nothing in the current revision of the KEP which depends on device classes
1276+
being mandatory, therefore the `DeviceClassName` is optional. Before beta we need
1277+
to decide whether we keep that or make it required. Changing after beta will be
1278+
harder.
1279+
1280+
<<[/UNRESOLVED]>>
1281+
```
1282+
1283+
```go
12701284

12711285
// Exactly one field must be set.
12721286
type Selector struct {

0 commit comments

Comments
 (0)