Skip to content

Commit 5a71bb5

Browse files
committed
Fixes based on review
1 parent d12d2cc commit 5a71bb5

File tree

1 file changed

+6
-1
lines changed
  • keps/sig-node/4817-resource-claim-device-status

1 file changed

+6
-1
lines changed

keps/sig-node/4817-resource-claim-device-status/README.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,6 @@ type AllocatedDeviceStatus struct {
210210
// NetworkData contains network-related information specific to the device.
211211
//
212212
// +optional
213-
// +oneOf=DeviceDataType
214213
NetworkData NetworkDeviceData `json:"networkData,omitempty" protobuf:"bytes,6,opt,name=networkData"`
215214
}
216215

@@ -321,6 +320,12 @@ allocated to a node. Additionally, the allocated node where the `ResourceClaim`
321320
is assigned will be used to check if the user/entity updating the
322321
`ResourceClaim.Status.Devices` is running on the same node.
323322

323+
The allocated node for the `ResourceClaim` must be unique in the form of
324+
`nodeSelector.nodeSelectorTerms[0].matchFields[0].values[0] = <NodeName>` and
325+
`nodeSelector.nodeSelectorTerms[0].matchFields[0].key = metadata.name` and
326+
`nodeSelector.nodeSelectorTerms[0].matchFields[0].operator = In`. Without this
327+
unique format, the update of the devices in the status will be rejected.
328+
324329
Here is a `ResourceClaim` allocated on a node. This would only work for now if
325330
exactly one node is set:
326331
```yaml

0 commit comments

Comments
 (0)