Skip to content

Commit 5f2df98

Browse files
ryanzhang-ossRyan Zhang
authored andcommitted
address comments
1 parent 340745d commit 5f2df98

File tree

1 file changed

+4
-6
lines changed
  • keps/sig-multicluster/4322-cluster-inventory

1 file changed

+4
-6
lines changed

keps/sig-multicluster/4322-cluster-inventory/README.md

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -313,8 +313,7 @@ the API proposed by this KEP aims to
313313
and keeps their status up-to-date. Each cluster manager MUST be identified with a unique name.
314314
Each ClusterProfile resource SHOULD be managed by only one cluster manager. A cluster manager SHOULD
315315
have sufficient permission to access the member cluster to fetch the information so it can update the status
316-
of the ClusterProfile API resource. Examples of cluster manager are projects like [OCM](https://open-cluster-management.io/),
317-
[Clusternet](https://clusternet.io/), [Kubernetes Fleet Manager](https://github.com/Azure/fleet) or [Karmada](https://karmada.io/).
316+
of the ClusterProfile API resource.
318317

319318
- **ClusterProfile API Consumer**: the person running the cluster managers
320319
or the person developing extensions for cluster managers for the purpose of
@@ -395,9 +394,9 @@ Note that a cluster can only be in one ClusterSet while there is not such restri
395394

396395
#### How should the API be consumed?
397396
We recommend that all ClusterProfile objects within the same cluster inventory reside on
398-
a dedicated hub Kubernetes cluster. This approach allows consumers to have a single integration
397+
a dedicated Kubernetes cluster (aka. the hub cluster). This approach allows consumers to have a single integration
399398
point to access all the information within a cluster inventory. Additionally, a multi-cluster aware
400-
controller can be run on the hub cluster to offer high-level functionalities over this inventory of clusters.
399+
controller can be run on the dedicated cluster to offer high-level functionalities over this inventory of clusters.
401400

402401
#### How should we organize ClusterProfile objects on a hub cluster?
403402
While there are no strict requirements, we recommend making the ClusterProfile API a namespace-scoped object.
@@ -406,8 +405,7 @@ certain clusters within the inventory.
406405

407406
However, if a cluster inventory represents a ClusterSet, all its ClusterProfile objects MUST be part of the same clusterSet
408407
and namespace must be used as the grouping mechanism. In addition, the namespace must have a label with the key "clusterset.multicluster.x-k8s.io"
409-
and the value as the name of the clusterSet. It's important to note that this means users would lose the ability to apply Kubernetes'
410-
native namespace-based RBAC within a clusterSet since Kubernetes does not support nested namespaces.
408+
and the value as the name of the clusterSet.
411409

412410
#### Uniqueness of the ClusterProfile object
413411
While there are no strict requirements, we recommend that there is only one ClusterProfile object representing any member cluster

0 commit comments

Comments
 (0)