You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
+ invalidStr := fmt.Sprintf("must be greater than 0 and less than terminationGracePeriodSeconds (%d)", *gracePeriod)
214
+
+ invalidStr := fmt.Sprintf("must be greater than 0 and less than terminationGracePeriodSeconds (%d). Please enable PodLifecycleSleepActionAllowZero feature gate if you need a sleep of zero duration.", *gracePeriod)
@@ -291,19 +291,18 @@ This can inform certain test coverage improvements that we want to do before
291
291
extending the production code to implement this enhancement.
292
292
-->
293
293
294
-
-`<package>`: `<date>` - `<test coverage>`
295
-
296
294
Alpha:
297
295
298
296
- Test that the runSleepHandler function returns immediately when given a duration of zero.
299
297
- Test that the validation succeeds when given a zero duration with the feature gate enabled.
300
298
- Test that the validation fails when given a zero duration with the feature gate disabled.
301
299
- Test that the validation returns the appropriate error messages when given an invalid duration value (e.g., a negative value) with the feature gate disabled and enabled.
300
+
- Unit tests for testing the disabling of the feature gate after it was enabled and the feature was used.
@@ -366,10 +365,9 @@ The previous PreStop Sleep Action behavior will not be broken. Users can continu
366
365
367
366
#### Downgrade
368
367
369
-
If the kube-apiserver is downgraded to a version where the feature gate is not supported (<v1.32), no new resources can be created with a PreStop sleep duration of zero seconds. Existing resources will continue to function, but they cannot be updated since the validation for the sleep duration would fail if the value is set to zero. Cluster admins can update their resources to have a non-zero value for the sleep duration and migrate their resources if they want to update it.
370
-
371
-
If the feature gate is turned off after being enabled, no new resources can be created with PreStop sleep duration of zero seconds. Existing resources will continue to function, but as discussed in the Proposal section, the sleep duration will need to be updated to a non-zero value if the resource has to be updated.
368
+
If the kube-apiserver is downgraded to a version where the feature gate is not supported (<v1.32), no new resources can be created with a PreStop sleep duration of zero seconds. Existing resources created with a sleep duration of zero will continue to function.
372
369
370
+
If the feature gate is turned off after being enabled, no new resources can be created with PreStop sleep duration of zero seconds. Existing resources will continue to run and use a sleep duration of zero seconds. These resources can be updated and the zero sleep duration would continue to work.
0 commit comments