Skip to content

Commit 630dd62

Browse files
committed
Apply feedback
1 parent 2edd5fc commit 630dd62

File tree

1 file changed

+11
-5
lines changed
  • keps/sig-api-machinery/3488-cel-admission-control

1 file changed

+11
-5
lines changed

keps/sig-api-machinery/3488-cel-admission-control/README.md

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1043,6 +1043,7 @@ The enum options will be:
10431043
- `warn`: Validation failures are reported as warnings to the client. (xref: [Admisssion Webhook Warnings](https://kubernetes.io/blog/2020/09/03/warnings/#admission-webhooks))
10441044
- `audit`: Validation failures are published as audit events (see below Audit
10451045
Annotations section for details).
1046+
- `log`: The apiserver handling the admission request logs the validation failure.
10461047

10471048
Systems that need to aggregate validation failures may implement an [audit
10481049
webhook
@@ -1075,11 +1076,16 @@ This enables the following use cases:
10751076

10761077
Future work:
10771078

1078-
ValidatingAdmissionPolicy resources might, in the future, add a `warnings` field
1079-
adjacent to the `validations` and `auditAnnotations` fields to declare
1080-
expressions only ever result in warnings. This would allow
1081-
ValidatingAdmissionPolicy authors to declare a expression as non-enforcing
1082-
regardless of `validationActions`.
1079+
- ValidatingAdmissionPolicy resources might, in the future, add a `warnings`
1080+
field adjacent to the `validations` and `auditAnnotations` fields to declare
1081+
expressions only ever result in warnings. This would allow
1082+
ValidatingAdmissionPolicy authors to declare a expression as non-enforcing
1083+
regardless of `validationActions`.
1084+
1085+
- ValidatingAdmissionPolicy resources, might, in the future, offer per-expression
1086+
enforcement actions (instead of a separate `warnings` field) and combine these
1087+
enforcement actions with the ValidatingAdmissionPolicyBinding enforcement action
1088+
to determine the effective enforcement.
10831089

10841090
#### Audit Annotations
10851091

0 commit comments

Comments
 (0)