Skip to content

Commit 63c30cc

Browse files
committed
Add ut coverage and how to check the feature
Signed-off-by: Jian Qiu <[email protected]>
1 parent bb6d4be commit 63c30cc

File tree

1 file changed

+13
-2
lines changed
  • keps/sig-auth/5284-constrained-impersonation

1 file changed

+13
-2
lines changed

keps/sig-auth/5284-constrained-impersonation/README.md

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -645,7 +645,10 @@ This can inform certain test coverage improvements that we want to do before
645645
extending the production code to implement this enhancement.
646646
-->
647647

648-
- `<package>`: `<date>` - `<test coverage>`
648+
- `k8s.io/apiserver/pkg/endpoints/filters`: `2025/06/13` - `75.5%`
649+
650+
Unit tests should cover authorization request with and without the feature enabled.
651+
649652

650653
##### Integration tests
651654

@@ -786,6 +789,8 @@ Below are some examples to consider, in addition to the aforementioned [maturity
786789

787790
- Determine if additional tests are necessary
788791
- Ensure reliability of existing tests
792+
- Determine if some caching mechanism should be introduced to reduce the extra
793+
permission check call
789794

790795
#### GA
791796

@@ -902,6 +907,8 @@ You can take a look at one potential example of such test in:
902907
https://github.com/kubernetes/kubernetes/pull/97058/files#diff-7826f7adbc1996a05ab52e3f5f02429e94b68ce6bce0dc534d1be636154fded3R246-R282
903908
-->
904909

910+
Yes, this will be covered in the unit tests and integration tests.
911+
905912
### Rollout, Upgrade and Rollback Planning
906913

907914
<!--
@@ -963,6 +970,9 @@ checking if there are objects with field X set) may be a last resort. Avoid
963970
logs or events for this purpose.
964971
-->
965972

973+
It should be user to set the permissions for the controllers. The operator should
974+
not set these permissions for the workload.
975+
966976
###### How can someone using this feature know that it is working for their instance?
967977

968978
<!--
@@ -980,7 +990,8 @@ Recall that end users cannot usually observe component logs or access metrics.
980990
- Condition name:
981991
- Other field:
982992
- [ ] Other (treat as last resort)
983-
- Details:
993+
- Details: User creates the permission and check if the impersonate on certain action
994+
works.
984995

985996
###### What are the reasonable SLOs (Service Level Objectives) for the enhancement?
986997

0 commit comments

Comments
 (0)