Skip to content

Commit 65a5008

Browse files
committed
first portion of comments by soltysh@ applied
1 parent bd7922d commit 65a5008

File tree

1 file changed

+5
-12
lines changed
  • keps/sig-scheduling/5278-nominated-node-name-for-expectation

1 file changed

+5
-12
lines changed

keps/sig-scheduling/5278-nominated-node-name-for-expectation/README.md

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -395,7 +395,9 @@ to implement this enhancement.
395395

396396
##### Unit tests
397397

398-
- `k8s.io/kubernetes/pkg/scheduler`: `2025-05-28` - `81.4`
398+
- `k8s.io/kubernetes/pkg/scheduler`: `2025-10-15` - `70.8`
399+
- `k8s.io/kubernetes/pkg/registry/core/pod/storage`: `2025-10-15` - `78.8`
400+
- `k8s.io/kubernetes/pkg/apis/core/validation`: `2025-10-15` - `85.2`
399401

400402
##### Integration tests
401403

@@ -484,7 +486,7 @@ Pods that are processed by Permit or PreBind plugins get NominatedNodeName durin
484486
###### Can the feature be disabled once it has been enabled (i.e. can we roll back the enablement)?
485487

486488
Yes.
487-
The feature can be disabled in Beta version by restarting the kube-scheduler and kube-apiserver with the feature-gate off.
489+
The feature can be disabled in Beta version by restarting the kube-scheduler and kube-apiserver with the feature-gates off.
488490

489491
###### What happens if we reenable the feature if it was previously rolled back?
490492

@@ -517,16 +519,7 @@ there'll be nothing behaving wrong in the scheduling flow, see [Version Skew Str
517519

518520
###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?
519521

520-
We will do the following manual test after implementing the feature:
521-
522-
1. upgrade
523-
2. set NNN to non-existing node
524-
3. ensure it won't get cleared
525-
4. downgrade
526-
5. ensure that it gets cleared
527-
6. upgrade
528-
7. set NNN to non-existing node
529-
8. ensure it isn't cleared again
522+
TODO: update the test scenario
530523

531524
###### Is the rollout accompanied by any deprecations and/or removals of features, APIs, fields of API types, flags, etc.?
532525

0 commit comments

Comments
 (0)