Skip to content

Commit 6805e7a

Browse files
committed
fixup: address comments
1 parent 59cdab6 commit 6805e7a

File tree

1 file changed

+20
-9
lines changed
  • keps/sig-scheduling/3521-pod-scheduling-readiness

1 file changed

+20
-9
lines changed

keps/sig-scheduling/3521-pod-scheduling-readiness/README.md

Lines changed: 20 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ tags, and then generate with `hack/update-toc.sh`.
7676
- [Motivation](#motivation)
7777
- [Goals](#goals)
7878
- [Non-Goals](#non-goals)
79+
- [Future Work](#future-work)
7980
- [Proposal](#proposal)
8081
- [User Stories (Optional)](#user-stories-optional)
8182
- [Story 1](#story-1)
@@ -228,6 +229,11 @@ and make progress.
228229
- Enforce updating the Pod's conditions to expose more context for scheduling-paused Pods.
229230
- Focus on in-house use-cases of the Enqueue extension point.
230231

232+
### Future Work
233+
234+
- Permission control on individual schedulingGate (via
235+
[fine-grained permissions](https://docs.google.com/document/d/11g9nnoRFcOoeNJDUGAWjlKthowEVM3YGrJA3gLzhpf4))
236+
231237
## Proposal
232238

233239
<!--
@@ -521,9 +527,8 @@ The following scenarios need to be covered in integration tests:
521527
can be moved back to activeQ when `.spec.schedulingGates` is all cleared
522528
- Ensure no significant performance degradation
523529

524-
- `test/integration/scheduler/queue_test.go`: added in Alpha.
525-
- `test/integration/scheduler/plugins/plugins_test.go`: added in Alpha.
526-
- `test/integration/scheduler/enqueue/enqueue_test.go`: added in Alpha.
530+
- `test/integration/scheduler/queue_test.go#TestSchedulingGates`: [k8s-triage](https://storage.googleapis.com/k8s-triage/index.html?sig=scheduling&test=TestSchedulingGates)
531+
- `test/integration/scheduler/plugins/plugins_test.go#TestPreEnqueuePlugin`: [k8s-triage](https://storage.googleapis.com/k8s-triage/index.html?sig=scheduling&test=TestPreEnqueuePlugin)
527532
- `test/integration/scheduler_perf/scheduler_perf_test.go`: will add in Beta. (https://storage.googleapis.com/k8s-triage/index.html?test=BenchmarkPerfScheduling)
528533

529534
##### e2e tests
@@ -545,6 +550,8 @@ An e2e test was created in Alpha with the following sequences:
545550
- Clear the Pod's `.spec.schedulingGates` field.
546551
- Wait for 5 seconds for the Pod to be scheduled; otherwise error the e2e test.
547552

553+
In beta, it will be enabled by default in the [k8s-triage](https://storage.googleapis.com/k8s-triage/index.html?sig=scheduling&test=Feature%3APodSchedulingReadiness) dashboard.
554+
548555
### Graduation Criteria
549556

550557
<!--
@@ -620,8 +627,6 @@ in back-to-back releases.
620627
#### Beta
621628

622629
- Feature enabled by default.
623-
- Permission control on individual schedulingGate is applicable (via
624-
[fine-grained permissions](https://docs.google.com/document/d/11g9nnoRFcOoeNJDUGAWjlKthowEVM3YGrJA3gLzhpf4)).
625630
- Gather feedback from developers and out-of-tree plugins.
626631
- Benchmark tests passed, and there is no performance degradation.
627632
- Update documents to reflect the changes.
@@ -768,7 +773,7 @@ You can take a look at one potential example of such test in:
768773
https://github.com/kubernetes/kubernetes/pull/97058/files#diff-7826f7adbc1996a05ab52e3f5f02429e94b68ce6bce0dc534d1be636154fded3R246-R282
769774
-->
770775

771-
Appropriate tests will be added in Alpha. See [Test Plan](#test-plan) for more details.
776+
Appropriate tests have been added in the integration tests. See [Integration tests](#integration-tests) for more details.
772777

773778
### Rollout, Upgrade and Rollback Planning
774779

@@ -818,6 +823,10 @@ are missing a bunch of machinery and tooling and can't do that now.
818823

819824
It will be tested manually prior to beta launch.
820825

826+
<<UNRESOLVED>>
827+
Add detailed scenarios and result here, and cc @wojtek-t.
828+
<</UNRESOLVED>>
829+
821830
###### Is the rollout accompanied by any deprecations and/or removals of features, APIs, fields of API types, flags, etc.?
822831

823832
<!--
@@ -978,6 +987,9 @@ Focusing mostly on:
978987
heartbeats, leader election, etc.)
979988
-->
980989

990+
The feature itself doesn't generate API calls. But it's expected the API Server would receive
991+
additional update/patch requests to mutate the scheduling gates, by external controllers.
992+
981993
###### Will enabling / using this feature result in introducing new API types?
982994

983995
<!--
@@ -987,8 +999,7 @@ Describe them, providing:
987999
- Supported number of objects per namespace (for namespace-scoped objects)
9881000
-->
9891001

990-
The feature itself doesn't generate API calls. But it's expected the API Server would receive
991-
additional update/patch requests to mutate the scheduling gates, by external controllers.
1002+
No.
9921003

9931004
###### Will enabling / using this feature result in any new calls to the cloud provider?
9941005

@@ -1025,7 +1036,7 @@ Think about adding additional work or introducing new steps in between
10251036
[existing SLIs/SLOs]: https://git.k8s.io/community/sig-scalability/slos/slos.md#kubernetes-slisslos
10261037
-->
10271038

1028-
This delay should be negligible.
1039+
No.
10291040

10301041
###### Will enabling / using this feature result in non-negligible increase of resource usage (CPU, RAM, disk, IO, ...) in any components?
10311042

0 commit comments

Comments
 (0)