Skip to content

Commit 6893af8

Browse files
authored
Merge pull request #4866 from AxeZhan/ga3960
[KEP 3960]: Promote PodLifecycleSleepAction to stable
2 parents 28ae516 + 3455bfd commit 6893af8

File tree

3 files changed

+10
-6
lines changed

3 files changed

+10
-6
lines changed

keps/prod-readiness/sig-node/3960.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,3 +6,5 @@ alpha:
66
approver: "@wojtek-t"
77
beta:
88
approver: "@wojtek-t"
9+
stable:
10+
approver: "@wojtek-t"

keps/sig-node/3960-pod-lifecycle-sleep-action/README.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ Items marked with (R) are required *prior to targeting to a milestone / release*
4747
- [x] (R) Design details are appropriately documented
4848
- [x] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors)
4949
- [x] e2e Tests for all Beta API Operations (endpoints)
50-
- [ ] (R) Ensure GA e2e tests meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
51-
- [ ] (R) Minimum Two Week Window for GA e2e tests to prove flake free
50+
- [x] (R) Ensure GA e2e tests meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
51+
- [x] (R) Minimum Two Week Window for GA e2e tests to prove flake free
5252
- [x] (R) Graduation criteria is in place
5353
- [ ] (R) [all GA Endpoints](https://github.com/kubernetes/community/pull/1806) must be hit by [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
5454
- [x] (R) Production readiness review completed
@@ -289,6 +289,7 @@ Tests List
289289

290290
- No negative feedback
291291
- No bug issues reported
292+
- [e2e tests](https://github.com/kubernetes/kubernetes/blob/94df29b8f278503c3b332280132202096e247128/test/e2e/common/node/lifecycle_hook.go#L550) are promoted to conformance
292293

293294
### Upgrade / Downgrade Strategy
294295

@@ -345,7 +346,7 @@ The change is opt-in, it doesn't impact already running workloads.
345346

346347
###### What specific metrics should inform a rollback?
347348

348-
Metric `sleep_action_terminated_early_total` will be added in beta.
349+
Users have to check Metric `sleep_action_terminated_early_total`.
349350
If it increases unreasonably, then user should check if something goes wrong and may need a rollback.
350351

351352
###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?
@@ -454,7 +455,8 @@ Disable PodLifecycleSleepAction feature gate, and restart related components.
454455

455456
- 2023-04-22: Initial draft KEP
456457
- 2023-12-20: Target to beta in v1.30
457-
458+
- 2024-09-21: Target to stable in v1.32
459+
458460
## Drawbacks
459461

460462
N/A

keps/sig-node/3960-pod-lifecycle-sleep-action/kep.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@ see-also: []
1515
replaces: []
1616

1717
# The target maturity stage in the current dev cycle for this KEP.
18-
stage: beta
18+
stage: stable
1919

2020
# The most recent milestone for which work toward delivery of this KEP has been
2121
# done. This can be the current (upcoming) milestone, if it is being actively
2222
# worked on.
23-
latest-milestone: "v1.30"
23+
latest-milestone: "v1.32"
2424

2525
# The milestone at which this feature was, or is targeted to be, at each stage.
2626
milestone:

0 commit comments

Comments
 (0)