You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: keps/sig-node/3960-pod-lifecycle-sleep-action/README.md
+6-4Lines changed: 6 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -47,8 +47,8 @@ Items marked with (R) are required *prior to targeting to a milestone / release*
47
47
-[x] (R) Design details are appropriately documented
48
48
-[x] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors)
49
49
-[x] e2e Tests for all Beta API Operations (endpoints)
50
-
-[] (R) Ensure GA e2e tests meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
51
-
-[] (R) Minimum Two Week Window for GA e2e tests to prove flake free
50
+
-[x] (R) Ensure GA e2e tests meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
51
+
-[x] (R) Minimum Two Week Window for GA e2e tests to prove flake free
52
52
-[x] (R) Graduation criteria is in place
53
53
-[ ] (R) [all GA Endpoints](https://github.com/kubernetes/community/pull/1806) must be hit by [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
54
54
-[x] (R) Production readiness review completed
@@ -289,6 +289,7 @@ Tests List
289
289
290
290
- No negative feedback
291
291
- No bug issues reported
292
+
- [e2e tests](https://github.com/kubernetes/kubernetes/blob/94df29b8f278503c3b332280132202096e247128/test/e2e/common/node/lifecycle_hook.go#L550) are promoted to conformance
292
293
293
294
### Upgrade / Downgrade Strategy
294
295
@@ -345,7 +346,7 @@ The change is opt-in, it doesn't impact already running workloads.
345
346
346
347
###### What specific metrics should inform a rollback?
347
348
348
-
Metric `sleep_action_terminated_early_total` will be added in beta.
349
+
Users have to check Metric `sleep_action_terminated_early_total`.
349
350
If it increases unreasonably, then user should check if something goes wrong and may need a rollback.
350
351
351
352
###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?
@@ -454,7 +455,8 @@ Disable PodLifecycleSleepAction feature gate, and restart related components.
0 commit comments