Skip to content

Commit 68a0d04

Browse files
committed
Change feature gate in KEP-2902 to CPUManagerPolicyAlphaOptions
Signed-off-by: Kevin Klues <[email protected]>
1 parent eb4e089 commit 68a0d04

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

keps/sig-node/2902-cpumanager-distribute-cpus-policy-option/README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ When enabled, this will trigger the `CPUManager` to evenly distribute CPUs acros
7575
### Risks and Mitigations
7676

7777
The risks of adding this new feature are quite low.
78-
It is isolated to a specific policy option within the `CPUManager`, and is protected both by the option itself, as well as the `CPUManagerPolicyExperimentalOptions` feature gate (which is disabled by default).
78+
It is isolated to a specific policy option within the `CPUManager`, and is protected both by the option itself, as well as the `CPUManagerPolicyAlphaOptions` feature gate (which is disabled by default).
7979

8080
| Risk | Impact | Mitigation |
8181
| -------------------------------------------------| -------| ---------- |
@@ -149,7 +149,7 @@ No changes needed
149149
###### How can this feature be enabled / disabled in a live cluster?
150150

151151
- [X] Feature gate (also fill in values in `kep.yaml`)
152-
- Feature gate name: `CPUManagerPolicyExperimentalOptions`
152+
- Feature gate name: `CPUManagerPolicyAlphaOptions`
153153
- Components depending on the feature gate: `kubelet`
154154
- [X] Change the kubelet configuration to set a `CPUManager` policy of `static` and a `CPUManager` policy option of `distribute-cpus-across-numa`
155155
- Will enabling / disabling the feature require downtime of the control
@@ -161,14 +161,14 @@ No changes needed
161161
###### Does enabling the feature change any default behavior?
162162

163163
No. In order to trigger any of the new logic, three things have to be true:
164-
1. The `CPUManagerPolicyExperimentalOptions` feature gate must be enabled
164+
1. The `CPUManagerPolicyAlphaOptions` feature gate must be enabled
165165
1. The `static` `CPUManager` policy must be selected
166166
1. The new `distribute-cpus-across-numa` policy option must be selected
167167

168168
###### Can the feature be disabled once it has been enabled (i.e. can we roll back the enablement)?
169169

170170
Yes, the feature can be disabled by either:
171-
1. Disabling the `CPUManagerPolicyExperimentalOptions` feature gate
171+
1. Disabling the `CPUManagerPolicyAlphaOptions` feature gate
172172
1. Switching the `CPUManager` policy to `none`
173173
1. Removing `distribute-cpus-across-numa` from the list of `CPUManager` policy options
174174

@@ -254,3 +254,4 @@ No, the algorithm will run on a single `goroutine` with minimal memory requireme
254254
- 2021-08-26: Initial KEP created
255255
- 2021-08-30: Updates to fill out more sections, answer PRR questions
256256
- 2021-09-08: Change feature gate from `CPUManagerPolicyOptions` to `CPUManagerPolicyExperimentalOptions`
257+
- 2021-10-11: Change feature gate from `CPUManagerPolicyExperimentalOptions` to `CPUManagerPolicyAlphaOptions`

keps/sig-node/2902-cpumanager-distribute-cpus-policy-option/kep.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ milestone:
3131
# The following PRR answers are required at alpha release
3232
# List the feature gate name and the components for which it must be enabled
3333
feature-gates:
34-
- name: "CPUManagerPolicyExperimentalOptions"
34+
- name: "CPUManagerPolicyAlphaOptions"
3535
components:
3636
- kubelet
3737
disable-supported: true

0 commit comments

Comments
 (0)