api: use string() instead of .String() for Stage, Status

Author: spiffxp

api/proposal.go

@@ -44,10 +44,6 @@ var ValidStages = []Stage{
 	StableStage,
 }
 
-func (s Stage) String() string {
-	return string(s)
-}
-
 func (s Stage) IsValid() error {
 	for _, s2 := range ValidStages {
 		if s == s2 {
@@ -79,10 +75,6 @@ var ValidStatuses = []Status{
 	ReplacedStatus,
 }
 
-func (s Status) String() string {
-	return string(s)
-}
-
 func (s Status) IsValid() error {
 	for _, s2 := range ValidStatuses {
 		if s == s2 {

pkg/kepctl/commands/create.go

@@ -90,7 +90,7 @@ func addCreate(topLevel *cobra.Command) {
 		&co.State,
 		"state",
 		"s",
-		api.ProvisionalStatus.String(),
+		string(api.ProvisionalStatus),
 		"KEP State",
 	)
 

pkg/output/output.go

@@ -210,8 +210,8 @@ func DefaultPrintConfigs(names ...string) []PrintConfig {
 
 			return k.OwningSIG
 		}},
-		"Stage":  {"Stage", func(k *api.Proposal) string { return k.Stage.String() }},
-		"Status": {"Status", func(k *api.Proposal) string { return k.Status.String() }},
+		"Stage":  {"Stage", func(k *api.Proposal) string { return string(k.Stage) }},
+		"Status": {"Status", func(k *api.Proposal) string { return string(k.Status) }},
 		"Title": {"Title", func(k *api.Proposal) string {
 			if k.PRNumber == "" {
 				return k.Title

pkg/repo/query.go

@@ -140,10 +140,10 @@ func (r *Repo) Query(opts *QueryOpts) ([]*api.Proposal, error) {
 
 		logrus.Debugf("current KEP: %v", k)
 
-		if len(opts.Status) > 0 && !allowedStatus[k.Status.String()] {
+		if len(opts.Status) > 0 && !allowedStatus[string(k.Status)] {
 			continue
 		}
-		if len(opts.Stage) > 0 && !allowedStage[k.Stage.String()] {
+		if len(opts.Stage) > 0 && !allowedStage[string(k.Stage)] {
 			continue
 		}
 		if len(opts.PRRApprover) > 0 && !atLeastOne(k.PRRApprovers, allowedPRR) {

pkg/repo/query_test.go

@@ -100,8 +100,8 @@ func TestQuery(t *testing.T) {
 				name: "everything",
 				queryOpts: repo.QueryOpts{
 					Groups: []string{"sig-architecture"},
-					Status: []string{api.ProvisionalStatus.String()},
-					Stage:  []string{api.AlphaStage.String()},
+					Status: []string{string(api.ProvisionalStatus)},
+					Stage:  []string{string(api.AlphaStage)},
 					// TODO: PRRApprover: []string{""},
 					Author:   []string{"@rjbez17"},
 					Approver: []string{"@liggitt"},
@@ -137,7 +137,7 @@ func TestQuery(t *testing.T) {
 			{
 				name: "results",
 				queryOpts: repo.QueryOpts{
-					Status: []string{api.ProvisionalStatus.String()},
+					Status: []string{string(api.ProvisionalStatus)},
 				},
 				kepNames: []string{
 					"123-newstyle",
@@ -175,7 +175,7 @@ func TestQuery(t *testing.T) {
 			{
 				name: "alpha",
 				queryOpts: repo.QueryOpts{
-					Stage: []string{api.AlphaStage.String()},
+					Stage: []string{string(api.AlphaStage)},
 				},
 				kepNames: []string{
 					"123-newstyle",
@@ -185,7 +185,7 @@ func TestQuery(t *testing.T) {
 			{
 				name: "beta",
 				queryOpts: repo.QueryOpts{
-					Stage: []string{api.BetaStage.String()},
+					Stage: []string{string(api.BetaStage)},
 				},
 				kepNames: []string{
 					"404-question-not-found",
@@ -194,7 +194,7 @@ func TestQuery(t *testing.T) {
 			{
 				name: "stable",
 				queryOpts: repo.QueryOpts{
-					Stage: []string{api.StableStage.String()},
+					Stage: []string{string(api.StableStage)},
 				},
 				kepNames: []string{
 					"13-keps-as-crds",