You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On top of testing the validation itself, we will test that:
195
+
* An error is returned if `--enable-kubelet-cert-cn-validation` is set but `KubeletCertCNValidation` feature flag is not enabled.
196
+
* An error is returned if the feature `KubeletCertCNValidation` is enabled, `--enable-kubelet-cert-cn-validation` is set to true but `--kubelet-certificate-authority` is not set.
197
+
194
198
##### Integration tests
195
199
196
200
Integration tests will be added to ensure the following:
197
-
* An error is returned if `--enable-kubelet-cert-cn-validation` is set but `KubeletCertCNValidation` feature flag is not enabled.
198
-
* An error is returned if the feature `KubeletCertCNValidation` is enabled, `--enable-kubelet-cert-cn-validation` is set to true but `--kubelet-certificate-authority` is not set.
199
201
* Validation for custom certificates works if feature flag is not enabled.
200
202
* Validation for custom certificates works if feature flag enabled and `--enable-kubelet-cert-cn-validation` is not set or set to false.
201
203
* Validation for custom certificates fails if feature flag enabled, `--kubelet-certificate-authority` is set and `--enable-kubelet-cert-cn-validation` is set to true.
202
204
* Validation for kubernetes issued certificates works if feature flag enabled, `--kubelet-certificate-authority` is set and `--enable-kubelet-cert-cn-validation` is set to true.
203
205
204
206
##### e2e tests
205
207
206
-
We believe is likely end-to-end tests won't be needed as unit and integration tests will cover all the scenarios. If it's not possible to cover all the scenarios, we will add e2e tests. It's also quite likely that existing e2e tests will cover the new behavior once the feature gate is enabled, so new tests might only be needed for the transition period.
208
+
We will update the alpha kind e2e tests job to exercise this flow to start with, and once the functionality is beta, we will update all kind e2e test jobs to run with this verification.
207
209
208
210
### Graduation Criteria
209
211
@@ -216,6 +218,7 @@ We believe is likely end-to-end tests won't be needed as unit and integration te
0 commit comments