Skip to content

Commit 762be1f

Browse files
committed
replace with Deprecated feature gates
1 parent 334d04c commit 762be1f

File tree

2 files changed

+7
-10
lines changed

2 files changed

+7
-10
lines changed

keps/sig-network/4004-deprecate-kube-proxy-version/README.md

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
- [e2e tests](#e2e-tests)
1919
- [Graduation Criteria](#graduation-criteria)
2020
- [Alpha](#alpha)
21-
- [Beta](#beta)
2221
- [GA](#ga)
2322
- [Upgrade / Downgrade Strategy](#upgrade--downgrade-strategy)
2423
- [Version Skew Strategy](#version-skew-strategy)
@@ -148,10 +147,7 @@ to implement this enhancement.
148147

149148
- Created the feature gate, disabled by default.
150149
- Started looking for components that might be using the deprecated field.
151-
152-
#### Beta
153-
154-
- Make sure that upgrades to the Beta version will work across supported levels of [version skew](https://kubernetes.io/releases/version-skew-policy/).
150+
- Make sure it works fine on supported versions of [version skew](https://kubernetes.io/releases/version-skew-policy/).
155151

156152
#### GA
157153

@@ -191,7 +187,7 @@ I manually confirmed that restarting kubelet behaves as expected with feature ga
191187

192188
I've tried to simulate this manually by running (using `local-cluster-up.sh).
193189

194-
Cluster Version v1.31+, `FEATURE_GATES=DisableNodeKubeProxyVersion=false` (manual setting):
190+
Cluster Version v1.31+, `FEATURE_GATES=DisableNodeKubeProxyVersion=false` (default value):
195191

196192
```
197193
~ kubectl get nodes 127.0.0.1 -oyaml
@@ -290,7 +286,7 @@ N/A
290286

291287
* The value of the `kubeProxyVersion` field in nodeInfo is not empty.
292288

293-
2. Cluster Version v1.31+ `FEATURE_GATES=DisableNodeKubeProxyVersion=true` (default value)
289+
2. Cluster Version v1.31+ `FEATURE_GATES=DisableNodeKubeProxyVersion=true` (manual setting)
294290

295291
```
296292
git checkout master
@@ -338,7 +334,7 @@ N/A
338334

339335
* The value of the `kubeProxyVersion` field in nodeInfo is empty.
340336

341-
4. Cluster Version v1.31+ `FEATURE_GATES=DisableNodeKubeProxyVersion=false` (manual setting)
337+
4. Cluster Version v1.31+ `FEATURE_GATES=DisableNodeKubeProxyVersion=false` (default value)
342338

343339
```
344340
git checkout master
@@ -423,6 +419,8 @@ N/A.
423419

424420
\- 2024-06-10: Promoted to beta and add manual upgrade and rollback tests
425421

422+
\- 2024-08-25: Replace with Deprecated feature gates.
423+
426424
## Drawbacks
427425

428426
## Alternatives

keps/sig-network/4004-deprecate-kube-proxy-version/kep.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ latest-milestone: "v1.31"
2626

2727
# The milestone at which this feature was, or is targeted to be, at each stage.
2828
milestone:
29-
alpha: "v1.29"
30-
beta: "v1.31"
29+
deprecated: "v1.29"
3130
stable: "v1.33"
3231

3332
# The following PRR answers are required at alpha release

0 commit comments

Comments
 (0)