Skip to content

Commit 7982c8d

Browse files
committed
PRR: fix rollback metrics detection
Count of pods in failed + SMTAlignmentError can be used to decide a rollback. Signed-off-by: Francesco Romani <[email protected]>
1 parent fa154a7 commit 7982c8d

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

keps/sig-node/2625-cpumanager-policies-thread-placement/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,8 @@ No changes needed
280280
### Rollout, Upgrade and Rollback Planning
281281

282282
* **How can a rollout fail? Can it impact already running workloads?** Kubelet may fail to start. The kubelet may crash.
283-
* **What specific metrics should inform a rollback?** Not applicable
283+
* **What specific metrics should inform a rollback?**
284+
- the number of pod ending up in Failed for SMTAlignmentError could be used to decide a rollback.
284285
* **Were upgrade and rollback tested? Was upgrade->downgrade->upgrade path tested?** Not Applicable.
285286
* **Is the rollout accompanied by any deprecations and/or removals of features, APIs, fields of API types, flags, etc.?** No.
286287

keps/sig-node/2625-cpumanager-policies-thread-placement/kep.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ feature-gates:
3535
- name: "CPUManagerPolicyOptions"
3636
components:
3737
- kubelet
38-
disable-supported: false
38+
disable-supported: true
3939

4040
# The following PRR answers are required at beta release
4141
metrics: []

0 commit comments

Comments
 (0)