Skip to content

Commit 7beaaf9

Browse files
committed
fix based on the review
1 parent 03ccce9 commit 7beaaf9

File tree

1 file changed

+8
-3
lines changed
  • keps/sig-scheduling/3633-matchlabelkeys-to-podaffinity

1 file changed

+8
-3
lines changed

keps/sig-scheduling/3633-matchlabelkeys-to-podaffinity/README.md

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -734,7 +734,8 @@ You can take a look at one potential example of such test in:
734734
https://github.com/kubernetes/kubernetes/pull/97058/files#diff-7826f7adbc1996a05ab52e3f5f02429e94b68ce6bce0dc534d1be636154fded3R246-R282
735735
-->
736736

737-
No. But, the tests to confirm the behavior on switching the feature gate will be added.
737+
No. But, the tests to confirm the behavior on switching the feature gate will be added,
738+
https://github.com/kubernetes/kubernetes/issues/123156.
738739

739740
### Rollout, Upgrade and Rollback Planning
740741

@@ -770,8 +771,12 @@ that might indicate a serious problem?
770771

771772
- A spike on metric `schedule_attempts_total{result="error|unschedulable"}` when pods using this feature are added.
772773

773-
No need to check latency of the scheduler because the scheduler doesn't get changed at all for this feature.
774-
The only possibility is the bug in the Pod creation process in kube-apiserver and it results in some unintended scheduling.
774+
The only possibility of the bug is in the Pod creation process in kube-apiserver and it results in some unintended scheduling.
775+
776+
Also, the scheduler's latency may also get increased
777+
because of the additional calculation for the label selector made from `matchLabelKeys`/`mismatchLabelKeys`.
778+
But, it should be tiny increase because the scheduler doesn't get changed at all for this feature,
779+
and using `matchLabelKeys`/`mismatchLabelKeys` just equals to adding some Pods with additional label selectors to the cluster.
775780

776781
###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?
777782

0 commit comments

Comments
 (0)