Skip to content

Commit 7ea65ba

Browse files
committed
KEP-5073: Declarative Validation: fix listMapItem syntax to be aligned with named argument grammar
1 parent 05ee553 commit 7ea65ba

File tree

1 file changed

+7
-7
lines changed
  • keps/sig-api-machinery/5073-declarative-validation-with-validation-gen

1 file changed

+7
-7
lines changed

keps/sig-api-machinery/5073-declarative-validation-with-validation-gen/README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -771,7 +771,7 @@ The below rules are currently implemented or are very similar to an existing val
771771
list map item reference (virtual field)
772772
</td>
773773
<td style="background-color: null">
774-
`+k8s:listMapItem(pairs: [[key,value],...])`
774+
`+k8s:listMapItem(list-map-key-field-name: value,...])`
775775
</td>
776776
<td style="background-color: null">
777777
N/A
@@ -1159,8 +1159,8 @@ type CertificateSigningRequestStatus struct {
11591159
// +k8s:optional
11601160
// +k8s:listType=map
11611161
// +k8s:listMapKey=type
1162-
// +k8s:listMapItem([["type","Approved"]])=+k8s:immutable
1163-
// +k8s:listMapItem([["type","Denied"]])=+k8s:immutable
1162+
// +k8s:listMapItem(type: "Approved")=+k8s:immutable
1163+
// +k8s:listMapItem(type: "Denied")=+k8s:immutable
11641164
Conditions []CertificateSigningRequestCondition `json:"conditions,omitempty"`
11651165
}
11661166
```
@@ -1261,8 +1261,8 @@ type Config struct {
12611261
// +k8s:listType=map
12621262
// +k8s:listMapKey=type
12631263
// +k8s:union(union: terminalStatus)
1264-
// +k8s:listMapItem([["type","Succeeded"]])=+k8s:memberOf(group: terminalStatus)
1265-
// +k8s:listMapItem([["type","Failed"]])=+k8s:memberOf(group: terminalStatus)
1264+
// +k8s:listMapItem(type: "Succeeded")=+k8s:memberOf(group: terminalStatus)
1265+
// +k8s:listMapItem(type: "Failed")=+k8s:memberOf(group: terminalStatus)
12661266
Conditions []Condition `json:"conditions"`
12671267
}
12681268

@@ -1321,8 +1321,8 @@ type Config struct {
13211321
// +k8s:listType=map
13221322
// +k8s:listMapKey=type
13231323
// +k8s:union(union: terminalStatus)
1324-
// +k8s:listMapItem([["type","Succeeded"]])=+k8s:memberOf(group: terminalStatus)
1325-
// +k8s:listMapItem([["type","Failed"]])=+k8s:memberOf(group: terminalStatus)
1324+
// +k8s:listMapItem(type: "Succeeded")=+k8s:memberOf(group: terminalStatus)
1325+
// +k8s:listMapItem(type: "Failed")=+k8s:memberOf(group: terminalStatus)
13261326
Conditions []Condition `json:"conditions"`
13271327
}
13281328

0 commit comments

Comments
 (0)