Skip to content

Commit 83c6670

Browse files
committed
Add first PRR answers
Signed-off-by: Sascha Grunert <[email protected]>
1 parent 9f15141 commit 83c6670

File tree

3 files changed

+28
-11
lines changed

3 files changed

+28
-11
lines changed
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
kep-number: 4639
2+
alpha:
3+
approver: "@deads2k"

keps/sig-node/4639-oci-volume-source/README.md

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -590,15 +590,11 @@ well as the [existing list] of feature gates.
590590
[existing list]: https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/
591591
-->
592592

593-
- [ ] Feature gate (also fill in values in `kep.yaml`)
594-
- Feature gate name:
593+
- [x] Feature gate (also fill in values in `kep.yaml`)
594+
- Feature gate name: OCIVolume
595595
- Components depending on the feature gate:
596-
- [ ] Other
597-
- Describe the mechanism:
598-
- Will enabling / disabling the feature require downtime of the control
599-
plane?
600-
- Will enabling / disabling the feature require downtime or reprovisioning
601-
of a node?
596+
- kube-apiserver (API validation)
597+
- kubelet (volume mount)
602598

603599
###### Does enabling the feature change any default behavior?
604600

@@ -607,6 +603,8 @@ Any change of default behavior may be surprising to users or break existing
607603
automations, so be extremely careful here.
608604
-->
609605

606+
Yes, it makes the new `VolumeSource` API functional.
607+
610608
###### Can the feature be disabled once it has been enabled (i.e. can we roll back the enablement)?
611609

612610
<!--
@@ -620,8 +618,13 @@ feature.
620618
NOTE: Also set `disable-supported` to `true` or `false` in `kep.yaml`.
621619
-->
622620

621+
Yes, by disabling the feature gate. Existing workloads will not be affected by
622+
the change.
623+
623624
###### What happens if we reenable the feature if it was previously rolled back?
624625

626+
It will make the API functional again.
627+
625628
###### Are there any tests for feature enablement/disablement?
626629

627630
<!--
@@ -637,6 +640,9 @@ You can take a look at one potential example of such test in:
637640
https://github.com/kubernetes/kubernetes/pull/97058/files#diff-7826f7adbc1996a05ab52e3f5f02429e94b68ce6bce0dc534d1be636154fded3R246-R282
638641
-->
639642

643+
Yes, unit tests for the alpha release for each component. End-to-end (serial
644+
node) tests will be targeted for beta.
645+
640646
### Rollout, Upgrade and Rollback Planning
641647

642648
<!--

keps/sig-node/4639-oci-volume-source/kep.yaml

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,25 @@ owning-sig: sig-node
77
participating-sigs:
88
- sig-node
99
- sig-storage
10-
status: provisional
10+
status: implementable
1111
creation-date: 2024-05-17
1212
reviewers:
1313
- "@BigVan"
14-
- "@alice.doe"
14+
- "@ChaoyiHuang"
15+
- "@SergeyKanzhelev"
1516
- "@aojea"
17+
- "@arewm"
18+
- "@cgwalters"
19+
- "@haircommander"
1620
- "@humblec"
21+
- "@jsafrane"
22+
- "@mariasalcedo"
1723
- "@mikebrow"
1824
- "@mrunalp"
1925
- "@rchincha"
2026
- "@samuelkarp"
2127
- "@sftim"
28+
- "@sudo-bmitch"
2229
- "@syed"
2330
- "@vsoch"
2431
- "@xing-yang"
@@ -46,7 +53,8 @@ milestone:
4653
feature-gates:
4754
- name: OCIVolume
4855
components:
49-
- TBD
56+
- kube-apiserver
57+
- kubelet
5058
disable-supported: true
5159

5260
# The following PRR answers are required at beta release

0 commit comments

Comments
 (0)