Skip to content

Commit 85373c3

Browse files
authored
Merge pull request #5132 from cupnes/update-kep-4049
KEP-4049: Update KEP readme
2 parents 6a5d411 + 76b6b98 commit 85373c3

File tree

1 file changed

+26
-0
lines changed
  • keps/sig-storage/4049-storage-capacity-scoring-of-nodes-for-dynamic-provisioning

1 file changed

+26
-0
lines changed

keps/sig-storage/4049-storage-capacity-scoring-of-nodes-for-dynamic-provisioning/README.md

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,13 @@ tags, and then generate with `hack/update-toc.sh`.
8787
- [Story 1](#story-1)
8888
- [Story 2](#story-2)
8989
- [Notes/Constraints/Caveats (Optional)](#notesconstraintscaveats-optional)
90+
- [Risks and Mitigations](#risks-and-mitigations)
9091
- [Design Details](#design-details)
9192
- [Modify stateData to be able to store StorageCapacity](#modify-statedata-to-be-able-to-store-storagecapacity)
9293
- [Get the capacity of nodes for dynamic provisioning](#get-the-capacity-of-nodes-for-dynamic-provisioning)
9394
- [Scoring of nodes for dynamic provisioning](#scoring-of-nodes-for-dynamic-provisioning)
9495
- [Conditions for scoring static or dynamic provisioning](#conditions-for-scoring-static-or-dynamic-provisioning)
96+
- [Feature Gate Consolidation](#feature-gate-consolidation)
9597
- [Test Plan](#test-plan)
9698
- [Prerequisite testing updates](#prerequisite-testing-updates)
9799
- [Unit tests](#unit-tests)
@@ -263,6 +265,26 @@ Go in to as much detail as necessary here.
263265
This might be a good place to talk about core concepts and how they relate.
264266
-->
265267

268+
### Risks and Mitigations
269+
270+
<!--
271+
What are the risks of this proposal, and how do we mitigate? Think broadly.
272+
For example, consider both security and how this will impact the larger
273+
Kubernetes ecosystem.
274+
275+
How will security be reviewed, and by whom?
276+
277+
How will UX be reviewed, and by whom?
278+
279+
Consider including folks who also work outside the SIG or subproject.
280+
-->
281+
282+
| Risk | Impact | Mitigation |
283+
| -------------------------------------------------------------------------------- | ------ | -------------------------------------------------- |
284+
| Misconfiguration of storage capacity scoring parameters | Medium | Provide documentation |
285+
| Potential performance overhead due to additional scoring calculations | Low | Optimize scoring algorithms |
286+
| Loss of optimized scheduling after downgrading to a version without this feature | Medium | Explain the impact of downgrading in documentation |
287+
266288
## Design Details
267289

268290
<!--
@@ -468,6 +490,10 @@ func (pl *VolumeBinding) Score(ctx context.Context, cs *framework.CycleState, po
468490
}
469491
```
470492

493+
### Feature Gate Consolidation
494+
495+
The `StorageCapacityScoring` feature gate will now control the functionality previously managed by the `VolumeCapacityPriority` feature gate, which will be deprecated. This consolidation focuses on enabling node scoring based on storage capacity, limited to the behaviors necessary for `StorageCapacityScoring`. Specifically, [the utilization shape points](https://github.com/kubernetes/enhancements/tree/49cff2e7c62800d1c87dbf5fac02c506209d1409/keps/sig-storage/1845-prioritization-on-volume-capacity#configuring-the-utilization-shape-points) have been supported because they are required for `StorageCapacityScoring`. However, [the weight of storage class](https://github.com/kubernetes/enhancements/tree/49cff2e7c62800d1c87dbf5fac02c506209d1409/keps/sig-storage/1845-prioritization-on-volume-capacity#configuring-the-weight-of-storage-class) has not been implemented ([ref1](https://github.com/kubernetes/enhancements/blob/10ff969c18772dc82cda02f7e9140c4840413e5d/keps/sig-storage/1845-prioritization-on-volume-capacity/README.md?plain=1#L201-L203), [ref2](https://github.com/kubernetes/kubernetes/pull/96347/files#diff-c4f8e3891e057e1f662eda397ce4f97d29de7d779d8a886ba2ec5a6df6f9d989R44)), and there are no plans to require it for `StorageCapacityScoring`, so it will not be implemented. For more details on the original proposal, see [KEP-1845](https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/1845-prioritization-on-volume-capacity/README.md).
496+
471497
### Test Plan
472498

473499
<!--

0 commit comments

Comments
 (0)