Skip to content

Commit 8ba3145

Browse files
committed
Mark as implementable
And add Ci flake investigation.
1 parent b79ff5c commit 8ba3145

File tree

2 files changed

+17
-4
lines changed

2 files changed

+17
-4
lines changed

keps/sig-storage/3756-volume-reconstruction/README.md

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -328,6 +328,9 @@ a feature gate.
328328

329329
## Design Details
330330

331+
This section serves as a design document of the proposed *and* the old
332+
VolumeManager startup + volume reconstruction during that.
333+
331334
### Proposed VolumeManager startup
332335

333336
When kubelet starts, VolumeManager starts DSWP and reconciler
@@ -418,7 +421,6 @@ then periodically does:
418421
volume plugin to unmount them. Kubelet at least tries to unmount the
419422
directory and clean up any orphan files there.
420423

421-
422424
#### Observability
423425

424426
Today, any errors during volume reconstruction are exposed only as log messages.
@@ -540,8 +542,19 @@ We expect no non-infra related flakes in the last month as a GA graduation crite
540542
Both are for the old reconstruction code, we don't have a job that enables
541543
alpha features + runs `[Disruptive]` tests.
542544

543-
TODO: check why it's flaky. *235 failures (3 in last day) out of 130688 builds
544-
from 1/11/2023, 1:00:33 AM to 1/25/2023*
545+
Recent results:
546+
547+
> *235 failures (3 in last day) out of 130688 builds from 1/11/2023, 1:00:33 AM
548+
> to 1/25/2023*
549+
550+
I checked couple of the recent flakes and all failed because they could not
551+
create namespace for the test:
552+
553+
https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-cri-containerd-e2e-cos-gce-serial/1620328095124819968:
554+
555+
> Unexpected error while creating namespace: Post
556+
> "https://35.247.99.121/api/v1/namespaces": dial tcp 35.247.99.121:443:
557+
> connect: connection refused
545558
546559
### Graduation Criteria
547560

keps/sig-storage/3756-volume-reconstruction/kep.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ authors:
55
owning-sig: sig-storage
66
participating-sigs:
77
- sig-node
8-
status: provisional
8+
status: implementable
99
creation-date: 2023-01-20
1010
reviewers:
1111
- "@msau42"

0 commit comments

Comments
 (0)