Skip to content

Commit 8d15422

Browse files
committed
Address reviewer comments for v1.30
1 parent 9072dfe commit 8d15422

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
# The KEP must have an approver from the
2+
# "prod-readiness-approvers" group
3+
# of http://git.k8s.io/enhancements/OWNERS_ALIASES
4+
kep-number: 4176
5+
alpha:
6+
approver: "@jpbetz"

keps/sig-node/4176-cpumanager-spread-cpus-preferred-policy/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -501,7 +501,7 @@ If we reactivate the feature after a rollback, the outcome remains unchanged. Cu
501501

502502
###### Are there any tests for feature enablement/disablement?
503503

504-
A dedicated e2e test will validate the preservation of the default behavior when the feature gate is turned off or when the feature is unused. This will be conducted through two distinct test scenarios.
504+
A dedicated e2e test will validate the preservation of the default behavior when the feature gate is turned off, when the feature is unused, when `pread-physical-cpus-preferred` turns off but `CPUManagerPolicyAlphaOptions` is disabled. This will be conducted through three distinct test scenarios.
505505

506506
<!--
507507
The e2e framework does not currently support enabling or disabling feature
@@ -666,7 +666,7 @@ and creating new ones, as well as about cluster-level services (e.g. DNS):
666666
- Impact of its degraded performance or high-error rates on the feature:
667667
-->
668668

669-
This applies to any machines with hyper-threading enabled.
669+
No. It doesn't rely on other Kubernetes components.
670670

671671
### Scalability
672672

keps/sig-node/4176-cpumanager-spread-cpus-preferred-policy/kep.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ latest-milestone: "v1.29"
2626

2727
# The milestone at which this feature was, or is targeted to be, at each stage.
2828
milestone:
29-
alpha: "v1.29"
30-
beta: "v1.30"
31-
stable: "v1.32"
29+
alpha: "v1.30"
30+
beta: "v1.31"
31+
stable: "v1.33"
3232

3333
# The following PRR answers are required at alpha release
3434
# List the feature gate name and the components for which it must be enabled

0 commit comments

Comments
 (0)