Skip to content

Commit 8d37151

Browse files
committed
Address feedback
1 parent 82f393e commit 8d37151

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

keps/sig-node/20190717-seccomp-ga.md

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ status: provisional
3838
- [PodSecurityPolicy Update](#podsecuritypolicy-update)
3939
- [PodSecurityPolicy Enforcement](#podsecuritypolicy-enforcement)
4040
- [PodTemplates](#podtemplates)
41+
- [Upgrade / Downgrade](#upgrade--downgrade)
4142
- [Test Plan](#test-plan)
4243
- [Graduation Criteria](#graduation-criteria)
4344
- [Upgrade / Downgrade Strategy](#upgrade--downgrade-strategy)
@@ -115,7 +116,7 @@ GA will be covered by a separate KEP._
115116

116117
- Declare seccomp GA
117118
- Fully document and formally spec the feature support
118-
- Migrate the annotations to standard API fields
119+
- Add equivalent API fields to replace seccomp annotations
119120
- Deprecate the seccomp annotations
120121

121122
### Non-Goals
@@ -128,6 +129,7 @@ are out of scope, including:
128129
- Formally speccing the seccomp profile format in Kubernetes
129130
- Providing mechanisms for loading profiles from outside the static seccomp node directory
130131
- Changing the semantics around seccomp support
132+
- Windows support (seccomp is very linux-specific)
131133

132134
## Proposal
133135

@@ -139,7 +141,7 @@ specifies allowed profiles & a default profile.
139141

140142
#### Pod API
141143

142-
The Pod Seccomp API is immutable.
144+
The Pod Seccomp API is immutable, except in [`PodTemplates`](#podtemplates).
143145

144146
```go
145147
type PodSecurityContext struct {
@@ -200,7 +202,7 @@ type PodSecurityPolicySpec struct {
200202
}
201203

202204
type SeccompStrategyOptions struct {
203-
// The default profile to set on the pod, if non is specified.
205+
// The default profile to set on the pod, if none is specified.
204206
// The default MUST be allowed by the allowedProfiles.
205207
// +optional
206208
DefaultProfile *v1.SeccompProfile
@@ -315,13 +317,21 @@ version running the pod.
315317
PodTemplates (e.g. ReplaceSets, Deployments, StatefulSets, etc.) will be ignored. The
316318
field/annotation resolution will happen on template instantiation.
317319

320+
#### Upgrade / Downgrade
321+
322+
Nodes do not currently support in-place upgrades, so pods will be recreated on node upgrade and
323+
downgrade. No special handling or consideration is needed to support this.
324+
325+
On the API server side, we've already taken version skew in HA clusters into account. The same
326+
precautions make upgrade & downgrade handling a non-issue.
327+
318328
### Test Plan
319329

320330
Seccomp already has [E2E tests][], but the tests are guarded by the `[Feature:Seccomp]` tag and not
321331
run in the standard test suites.
322332

323333
Prior to being marked GA, the feature tag will be removed from the seccomp tests, and the tests will
324-
be migrated to the new fields API.
334+
be migrated to the new fields API. Tests will be tagged as `[LinuxOnly]`.
325335

326336
New tests will be added covering the annotation/field conflict cases described under
327337
[Version Skew Strategy](#version-skew-strategy).

0 commit comments

Comments
 (0)