Skip to content

Commit 8e3011b

Browse files
committed
Update language in to crd or not to crd
Signed-off-by: lauralorenz <[email protected]>
1 parent 91cc81c commit 8e3011b

File tree

1 file changed

+4
-2
lines changed
  • keps/sig-multicluster/2149-clusterid

1 file changed

+4
-2
lines changed

keps/sig-multicluster/2149-clusterid/README.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -499,7 +499,7 @@ spec:
499499

500500
_That is the question._
501501

502-
While this document has thus far referred to the `ClusterProperty` resource as being implemented as a CRD, another implementation point of debate has been whether this belongs in the core Kubernetes API, particularly the `cluster.clusterset.k8s.io ClusterProperty`. A dependable cluster id or cluster name has previously been discussed in other forums (such as [this SIG-Architecture thread](https://groups.google.com/g/kubernetes-sig-architecture/c/mVGobfD4TpY/m/nkdbkX1iBwAJ) from 2018, or, as mentioned above, the [Cluster API subproject](https://github.com/kubernetes-sigs/cluster-api/issues/4044) which implemented [their own solution](https://github.com/kubernetes-sigs/cluster-api/pull/4048).) It is the opinion of SIG-Multicluster that the function of the proposed `ClusterProperty` CRD is of broad utility and becomes more useful the more ubiquitous it is, not only in multicluster set ups.
502+
While this document has thus far referred to the `ClusterProperty` resource as being implemented as a CRD, another implementation point of debate has been whether this belongs in the core Kubernetes API, particularly the `cluster.clusterset.k8s.io ClusterProperty` and especially while it being discussed under the more general naming convention of `id.k8s.io`. A dependable cluster ID or cluster name has previously been discussed in other forums (such as [this SIG-Architecture thread](https://groups.google.com/g/kubernetes-sig-architecture/c/mVGobfD4TpY/m/nkdbkX1iBwAJ) from 2018, or, as mentioned above, the [Cluster API subproject](https://github.com/kubernetes-sigs/cluster-api/issues/4044) which implemented [their own solution](https://github.com/kubernetes-sigs/cluster-api/pull/4048).) While today the use case for the current well-known properties described in this KEP address specific needs for multicluster setups, it is the opinion of SIG-Multicluster that the function of the proposed `ClusterProperty` CRD is of broad utility and becomes more useful the more ubiquitous it is.
503503

504504
This has led to the discussion of whether or not we should pursue adding this resource type not as a CRD associated with SIG-Multicluster, but as a core Kubernetes API implemented in `kubernetes/kubernetes`. A short pro/con list is enclosed at the end of this section.
505505

@@ -514,7 +514,9 @@ One effect of that decision is related to the upgrade path. Implementing this re
514514
| Blockers | Official API review if using *.k8s.io | Official API review |
515515
| Conformance testing | Not possible now, and no easy path forward | Standard |
516516

517-
**In the end, SIG-Multicluster discussed this with SIG-Architecture and it was decided to stick with the plan to use a CRD.** Notes from this conversation are in the [SIG-Architecture meeting agenda](https://docs.google.com/document/d/1BlmHq5uPyBUDlppYqAAzslVbAO8hilgjqZUTaNXUhKM/preview) for 3/25/2021. A graduation criteria set for Alpha->Beta stage to fully immortalize this decision is intended to be the last chance to consider including this design in k/k or not.
517+
**In the end, SIG-Multicluster discussed this with SIG-Architecture and it was decided to stick with the plan to use a CRD.** Notes from this conversation are in the [SIG-Architecture meeting agenda](https://docs.google.com/document/d/1BlmHq5uPyBUDlppYqAAzslVbAO8hilgjqZUTaNXUhKM/preview) for 3/25/2021. A graduation criteria was set for Alpha->Beta stage to fully immortalize this decision, intended to be the last chance to consider including this design in k/k or not.
518+
519+
The largest concern within SIG-Multicluster regarding a CRD based implementation was the added difficulty of deployment. While at that time efforts were underway to address some of these concerns by providing a better ecosystem for CRD bootstrapping, there is as of yet no centralized solution for bootstrapping out-of-tree CRDs. For now, users of About API (and by extension, MCS API which depends on it) will need to manage their CRD installations carefully, until that is addressed out of scope of this KEP. This may become easier for the community to address as a whole as other CRD-based implementations of Kubernetes features also reach maturity.
518520

519521

520522
### Test Plan

0 commit comments

Comments
 (0)