Skip to content

Commit 9084d35

Browse files
committed
Address PRR review comments
1 parent b7b0e1d commit 9084d35

File tree

2 files changed

+16
-10
lines changed

2 files changed

+16
-10
lines changed

keps/sig-auth/4872-harden-kubelet-cert-validation/README.md

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -59,18 +59,18 @@ checklist items _must_ be updated for the enhancement to be released.
5959

6060
Items marked with (R) are required *prior to targeting to a milestone / release*.
6161

62-
- [ ] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR)
62+
- [x] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR)
6363
- [ ] (R) KEP approvers have approved the KEP status as `implementable`
64-
- [ ] (R) Design details are appropriately documented
64+
- [x] (R) Design details are appropriately documented
6565
- [ ] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors)
6666
- [ ] e2e Tests for all Beta API Operations (endpoints)
6767
- [ ] (R) Ensure GA e2e tests meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
6868
- [ ] (R) Minimum Two Week Window for GA e2e tests to prove flake free
69-
- [ ] (R) Graduation criteria is in place
70-
- [ ] (R) [all GA Endpoints](https://github.com/kubernetes/community/pull/1806) must be hit by [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
71-
- [ ] (R) Production readiness review completed
72-
- [ ] (R) Production readiness review approved
73-
- [ ] "Implementation History" section is up-to-date for milestone
69+
- [x] (R) Graduation criteria is in place
70+
- [x] (R) [all GA Endpoints](https://github.com/kubernetes/community/pull/1806) must be hit by [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
71+
- [x] (R) Production readiness review completed
72+
- [x] (R) Production readiness review approved
73+
- [x] "Implementation History" section is up-to-date for milestone
7474
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
7575
- [ ] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
7676

@@ -374,7 +374,9 @@ It's part of the API server, so the feature will be unavailable.
374374

375375
## Implementation History
376376

377-
* Implementation options discussion: https://docs.google.com/document/d/1RqhAkGov_coHsB3lbAo-qfQl1MOfYvgpPUjiGMJ_3PY
377+
* 2024-10-08: KEP created
378+
* 2025-05-08: Implementation options discussion: https://docs.google.com/document/d/1RqhAkGov_coHsB3lbAo-qfQl1MOfYvgpPUjiGMJ_3PY
379+
378380

379381
## Drawbacks
380382

keps/sig-auth/4872-harden-kubelet-cert-validation/kep.yaml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,11 @@ participating-sigs:
77
status: implementable
88
creation-date: 2024-09-24
99
reviewers:
10-
- TBD
10+
- "@enj"
11+
- "@liggitt"
1112
approvers:
12-
- TBD
13+
- "@enj"
14+
- "@liggitt"
1315

1416
see-also:
1517
replaces:
@@ -38,3 +40,5 @@ disable-supported: true
3840

3941
# The following PRR answers are required at beta release
4042
metrics:
43+
- "kube_apiserver_validation_kubelet_cert_cn_total"
44+
- "apiserver_request_duration_seconds"

0 commit comments

Comments
 (0)