Skip to content

Commit 923448c

Browse files
committed
Add required PodSandbox addition
Signed-off-by: Sascha Grunert <[email protected]>
1 parent 3f0bec8 commit 923448c

File tree

1 file changed

+24
-0
lines changed
  • keps/sig-node/4639-oci-volume-source

1 file changed

+24
-0
lines changed

keps/sig-node/4639-oci-volume-source/README.md

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -402,6 +402,10 @@ before the container gets started.
402402
If users want to re-pull artifacts when referencing moving tags like `latest`,
403403
then they need to restart / evict the pod.
404404

405+
The [AlwaysPullImages](https://kubernetes.io/docs/reference/access-authn-authz/admission-controllers/#alwayspullimages)
406+
admission plugin needs to respect the pull policy as well and has to set the
407+
field accordingly.
408+
405409
##### Registry authentication
406410

407411
For registry authentication purposes the same logic will be used as for the
@@ -441,6 +445,26 @@ plugin as part of the existing [volume manager](https://github.com/kubernetes/ku
441445

442446
The added `mount_label` allow the kubelet to support SELinux contexts.
443447

448+
The [`PodSandbox`](https://github.com/kubernetes/cri-api/blob/3a66d9d/pkg/apis/runtime/v1/api.proto#L624-L643)
449+
(used by `ListPodSandboxResponse` for the kubelet image garbage collection) will
450+
be extended to support a string list of user requested OCI volume mounts:
451+
452+
```protobuf
453+
message PodSandbox {
454+
// …
455+
456+
repeated string oci_volumes = 8;
457+
}
458+
```
459+
460+
This allows the kubelet to identify which OCI volume images are still in use by
461+
pods. It also requires runtimes to track the linked information between mounted
462+
OCI objects and the pod sandbox to:
463+
464+
- Prevent removing OCI objects which are still in use
465+
- Be able to provide the information which pod is using which mounted volumes to
466+
API consumers (kubelet image garbage collection or maybe kubectl)
467+
444468
#### Container Runtimes
445469

446470
Container runtimes need to support the new `mount` field, otherwise the

0 commit comments

Comments
 (0)