pkg/repo: avoid make for slice init

Initializing the slice with empty PRs broke PR-based KEP loading:

- the PR file loading code tried pulling files for PR number 0
- which returned an error
- which prevented any PR-based KEPs from loading

Opt to initiliaze slices as explicitly empty, since we don't really need
the efficiency gains of pre-allocation here.

Author: spiffxp

pkg/repo/query.go

@@ -99,7 +99,7 @@ func (r *Repo) Query(opts *QueryOpts) ([]*api.Proposal, error) {
 		}
 	}
 
-	allKEPs := make([]*api.Proposal, 0, 10)
+	allKEPs := []*api.Proposal{}
 	// load the KEPs for each listed SIG
 	for _, sig := range opts.Groups {
 		// KEPs in the local filesystem
@@ -132,7 +132,7 @@ func (r *Repo) Query(opts *QueryOpts) ([]*api.Proposal, error) {
 	allowedApprover := sliceToMap(opts.Approver)
 	allowedParticipant := sliceToMap(opts.Participant)
 
-	results := make([]*api.Proposal, 0, 10)
+	results := []*api.Proposal{}
 	for _, k := range allKEPs {
 		if k == nil {
 			return nil, errors.New("one of the KEPs in query was nil")

pkg/repo/repo.go

@@ -331,7 +331,7 @@ func (r *Repo) loadKEPPullRequests(sig string) ([]*api.Proposal, error) {
 		}
 	}
 
-	kepPRs := make([]*github.PullRequest, 10)
+	kepPRs := []*github.PullRequest{}
 	sigLabel := strings.Replace(sig, "-", "/", 1)
 	logrus.Debugf("Searching list of %v PRs for %v/%v with labels: [%v, %v]", len(r.allPRs), remoteOrg, remoteRepo, sigLabel, proposalLabel)
 	for _, pr := range r.allPRs {