Skip to content

Commit 9465f80

Browse files
committed
Resolve lmktfy's comments
Signed-off-by: Jian Qiu <[email protected]>
1 parent 66362d7 commit 9465f80

File tree

1 file changed

+6
-13
lines changed
  • keps/sig-auth/5284-constrained-impersonation

1 file changed

+6
-13
lines changed

keps/sig-auth/5284-constrained-impersonation/README.md

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -118,12 +118,11 @@ tags, and then generate with `hack/update-toc.sh`.
118118
- [Drawbacks](#drawbacks)
119119
- [Alternatives](#alternatives)
120120
- [Use <code>impersonate:user-info</code> instead of <code>impersonate:serviceaccount</code> and <code>impersonate:node</code>](#use-impersonateuser-info-instead-of-impersonateserviceaccount-and-impersonatenode)
121-
- [Subject Access Review](#subject-access-review)
121+
- [Controller participation in SubjectAccessReview for impersonation](#controller-participation-in-subjectaccessreview-for-impersonation)
122122
- [Setting a special APIGroup suffix instead of special verb](#setting-a-special-apigroup-suffix-instead-of-special-verb)
123123
- [Check permission intersection of impersonator and target user](#check-permission-intersection-of-impersonator-and-target-user)
124124
- [Expand RBAC/SAR](#expand-rbacsar)
125125
- [Conditional Authorization](#conditional-authorization)
126-
- [Infrastructure Needed (Optional)](#infrastructure-needed-optional)
127126
<!-- /toc -->
128127

129128
## Release Signoff Checklist
@@ -905,6 +904,8 @@ Below are some examples to consider, in addition to the aforementioned [maturity
905904
- Determine if additional tests are necessary
906905
- Ensure reliability of existing tests
907906
- Determine if some mechanism should be introduced to reduce the extra permission checks
907+
- Alternatives have been reviewed, and we have consensus not to switch to an alternative
908+
approach.
908909

909910
#### GA
910911

@@ -1122,7 +1123,7 @@ Recall that end users cannot usually observe component logs or access metrics.
11221123
- [ ] API .status
11231124
- Condition name:
11241125
- Other field:
1125-
- [ ] Other (treat as last resort)
1126+
- [x] Other (treat as last resort)
11261127
- Details: User creates the permission and check if the impersonate on certain action
11271128
works.
11281129

@@ -1367,7 +1368,7 @@ verbs would delegation of permissions and support more expressions:
13671368
serviceaccounts in a certain namespace.
13681369
- Verb `impersonate:node` can support a permission to allow impersonating any node.
13691370

1370-
### Subject Access Review
1371+
### Controller participation in SubjectAccessReview for impersonation
13711372

13721373
The controller can sends a SAR request, and then uses its own permission to perform the action.
13731374
The main difference from impersonation is:
@@ -1439,14 +1440,6 @@ introduce change on RBAC/SAR.
14391440

14401441
Conditional authorization is the emerging work to provide more complicated authorization policy
14411442
with CEL expressions. Potentially it would be able to reduce the number of permission checks for the impersonation
1442-
in this proposal. The work is still in very early stage, and will bring many changes in the exising authorization
1443+
in this proposal. The work is still in very early stage, and will bring many changes in the existing authorization
14431444
model. It is possible to enhance constrained impersonation in this proposal with conditional authorization in the
14441445
future.
1445-
1446-
## Infrastructure Needed (Optional)
1447-
1448-
<!--
1449-
Use this section if you need things from the project/SIG. Examples include a
1450-
new subproject, repos requested, or GitHub details. Listing these here allows a
1451-
SIG to get the process for these resources started right away.
1452-
-->

0 commit comments

Comments
 (0)