@@ -1165,7 +1165,7 @@ Constraints](https://github.com/kubernetes/enhancements/tree/master/keps/sig-api
1165
1165
1166
1166
- CEL estimated cost limits
1167
1167
- CEL runtime cost limits
1168
- - Go context cancelation as a way of halting CEL execution if the request
1168
+ - Go context cancellation as a way of halting CEL execution if the request
1169
1169
context is canceled for any reason.
1170
1170
1171
1171
Estimated cost is, unfortunately, not something we can offer for admission with
@@ -1174,19 +1174,19 @@ Constraints](https://github.com/kubernetes/enhancements/tree/master/keps/sig-api
1174
1174
for the same cases where we provide informational type checking, in which case
1175
1175
we can report any cost limit violations in the same way we report type checking
1176
1176
violations. Note that for built-in types, where `max{Length,Items,Properties}`
1177
- value valiations are not available, estimated cost calculations will not be
1178
- nearly as helpful or actionable. I recommend we do not attempt any estimated
1179
- cost calculations on built-in types until the value validations are available .
1177
+ value validations are not available, estimated cost calculations will not be
1178
+ nearly as helpful or actionable. We do not plan to enforce any estimated
1179
+ cost calculations on ValidatingAdmissionPolicy .
1180
1180
1181
- Runtime cost limits can should be established and enforced. Exceeding the cost
1181
+ Runtime cost limits should be established and enforced. Exceeding the cost
1182
1182
limit will trigger the `FailurePolicy`, so this will need to be documented, but
1183
1183
unlike webhooks, runtime cost is deterministic (it is purely a function of the
1184
1184
input data and the CEL expression and is independent of underlying hardware or
1185
1185
system load), making it less of a concern for control plane availability than
1186
1186
webhook timeouts.
1187
1187
1188
1188
The request's Go context will be passed in to all CEL evaluations such that
1189
- cancelation halts CEL evaluation, if, for any reason, the context is canceled.
1189
+ cancellation halts CEL evaluation, if, for any reason, the context is canceled.
1190
1190
1191
1191
# ### Safety Features
1192
1192
0 commit comments