Skip to content

Commit 9c1678a

Browse files
Update README.md
Choice of max token lifetime was reconsidered during implementation. Documenting it accordingly. For ref: kubernetes/kubernetes#128190 (comment)
1 parent 7268ecc commit 9c1678a

File tree

1 file changed

+3
-3
lines changed
  • keps/sig-auth/740-service-account-external-signing

1 file changed

+3
-3
lines changed

keps/sig-auth/740-service-account-external-signing/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -245,12 +245,12 @@ message Key {
245245
message MetadataRequest {}
246246
247247
message MetadataResponse {
248-
// used by kube-apiserver for defaulting/validation of JWT lifetime while accounting for configuration flag values:
248+
// used by kube-apiserver as the max token lifetime and for validation against configuration flag values:
249249
// 1. `--service-account-max-token-expiration`
250250
// 2. `--service-account-extend-token-expiration`
251251
//
252-
// * If `--service-account-max-token-expiration` is greater than `max_token_expiration_seconds`, kube-apiserver treats that as misconfiguration and exits.
253-
// * If `--service-account-max-token-expiration` is not explicitly set, kube-apiserver defaults to `max_token_expiration_seconds`.
252+
// * If `--service-account-max-token-expiration` is set while external-jwt-signer is configured, kube-apiserver treats that as misconfiguration and exits.
253+
// * If `--service-account-max-token-expiration` is not set, kube-apiserver uses `max_token_expiration_seconds` as max token lifetime.
254254
// * If `--service-account-extend-token-expiration` is true, the extended expiration is `min(1 year, max_token_expiration_seconds)`.
255255
//
256256
// `max_token_expiration_seconds` must be at least 600s.

0 commit comments

Comments
 (0)