Skip to content

Commit a0ac8f1

Browse files
committed
KEP-4033: align to kubernetes deprecation policy
1 parent 72e7a4c commit a0ac8f1

File tree

1 file changed

+14
-6
lines changed
  • keps/sig-node/4033-group-driver-detection-over-cri

1 file changed

+14
-6
lines changed

keps/sig-node/4033-group-driver-detection-over-cri/README.md

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -185,9 +185,11 @@ message, e.g.:
185185
cgroupDriver option has been deprecated and will be dropped in a future release. Please upgrade to a CRI implementation that supports cgroup-driver detection.
186186
```
187187

188-
The `--cgroup-driver` flag will be completely removed when support for the
189-
feature is graduated to GA and the kubelet refuses to start if the CRI runtime
190-
does not support the feature.
188+
The `--cgroup-driver` flag and the cgroupDriver configuration option will be
189+
deprecated and have no effect when support for the feature is graduated to GA.
190+
The kubelet refuses to start if the CRI runtime does not support the feature.
191+
The configurations flags will ultimately be removed as per the
192+
[Kubernetes deprecation policy](https://kubernetes.io/docs/reference/using-api/deprecation-policy/#deprecating-a-flag-or-cli).
191193

192194
Kubelet startup is modified so that connection to the CRI server (container
193195
runtime) is established and RuntimeConfig is queried before initializing the
@@ -241,6 +243,7 @@ No new e2e tests for kubelet are planned.
241243

242244
- No bugs reported in the previous cycle.
243245
- Drop fallback to old behavior. CRI implementations expected to have support.
246+
- Deprecate kubelet cgroupDriver configuration option and `--cgroup-driver` flag.
244247
- Remove feature gate
245248
- All issues and gaps identified as feedback during beta are resolved
246249

@@ -289,8 +292,8 @@ scenarios where the kubelet `--cgroup-driver` setting is incorrectly
289292
configured). With old versions of the container runtimes (that don't support
290293
the new field in the CRI API) the default behavior is not changed.
291294

292-
In GA, the fallback behavior (and the kubelet `--cgroup-driver` flag) is
293-
removed and the kubelet requires the CRI runtime to implement the feature (see
295+
In GA, the fallback behavior is removed and the kubelet requires the CRI
296+
runtime to implement the feature (see
294297
[Version Skew Strategy](#version-skew-strategy)).
295298

296299
###### Can the feature be disabled once it has been enabled (i.e. can we roll back the enablement)?
@@ -337,7 +340,8 @@ In alpha and beta, the CgroupDriver field of the Kubelet configuration (and the
337340
corresponding `--cgroup-driver` flag) will be marked as deprecated.
338341

339342
In GA, the CgroupDriver configuration option and the `--cgroup-driver` flag are
340-
removed.
343+
deprecated, will have no effect, and will be removed in a future release as per
344+
the Kubernetes deprecation policy.
341345

342346
### Monitoring Requirements
343347

@@ -429,6 +433,10 @@ container runtime, only.
429433
In alpha and beta, same that exists today: Kubelet and the CRI server (container runtime) not
430434
agreeing on the CgroupDriver while one of them doesn’t support the feature.
431435

436+
In GA, the kubelet requires the CRI runtime to implement the feature and will
437+
refuse to start if it is not supported. As a result, the minimum required
438+
versions for containerd is v2.0 and for cri-o is v1.28.
439+
432440
###### What steps should be taken if SLOs are not being met to determine the problem?
433441

434442
N/A.

0 commit comments

Comments
 (0)