Skip to content

Commit a1b9721

Browse files
committed
clarify PRR questions
Signed-off-by: Nabarun Pal <[email protected]>
1 parent c651442 commit a1b9721

File tree

1 file changed

+19
-6
lines changed
  • keps/sig-auth/3221-structured-authorization-configuration

1 file changed

+19
-6
lines changed

keps/sig-auth/3221-structured-authorization-configuration/README.md

Lines changed: 19 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ Authorizer config. If healthcheck on the webhook failed, the last known good
305305
config will be used. In the next iteration of reload, if webhook is found to be
306306
healthy, the new config will be used. Logging and metrics would be used to
307307
signal success/failure of a config reload so that cluster admins can have
308-
observability over this process.Reload must not add or remove Node or RBAC
308+
observability over this process. Reload must not add or remove Node or RBAC
309309
authorizers. They can be reordered, but cannot be added or removed.
310310

311311
The proposed structure is illustrated below:
@@ -592,10 +592,13 @@ The behaviour is the same as when the feature is enabled for the first time.
592592

593593
###### Are there any tests for feature enablement/disablement?
594594

595-
> //TODO: How do we ensure functionality in the absence of e2e-framework not having support for feature gates?
595+
We will have extensive unit tests during feature implementation. There would be tests
596+
for the Authorizer chain in both the old and new configuration scenarios.
596597

597598
### Rollout, Upgrade and Rollback Planning
598599

600+
> Note: This section is required when targeting Beta to a release.
601+
599602
###### How can a rollout or rollback fail? Can it impact already running workloads?
600603

601604
A rollout can fail when the authorization configuration file being passed doesn't
@@ -625,7 +628,8 @@ For GA, this section is required: approvers should be able to confirm the
625628
previous answers based on experience in the field.
626629
-->
627630

628-
> //TODO: To be elaborated more during Beta graduation.
631+
> Note: To be elaborated more during Beta graduation since this section
632+
must be completed when targeting beta to a release.
629633

630634
###### How can an operator determine if the feature is in use by workloads?
631635

@@ -686,13 +690,15 @@ None
686690

687691
### Scalability
688692

693+
> Note: This section is good-to-have to Alpha.
694+
689695
###### Will enabling / using this feature result in any new API calls?
690696

691-
No.
697+
No. No additional calls will be made to the Kubernetes API Server.
692698

693699
###### Will enabling / using this feature result in introducing new API types?
694700

695-
No.
701+
Yes, but these are types for defining configuration and are not served.
696702

697703
###### Will enabling / using this feature result in any new calls to the cloud provider?
698704

@@ -725,7 +731,11 @@ This through this both in small and large cases, again with respect to the
725731
[supported limits]: https://git.k8s.io/community//sig-scalability/configs-and-limits/thresholds.md
726732
-->
727733

728-
No.
734+
There would a very small addition to the memory used by the API Server and
735+
number of log entries written to the disk. During the Alpha implementation,
736+
the small impact will be measured and rationalized to keep the addition
737+
minimal. The addition would be well within the scalability limits and
738+
thresholds.
729739

730740
### Troubleshooting
731741

@@ -740,6 +750,9 @@ splitting it into a dedicated `Playbook` document (potentially with some monitor
740750
details). For now, we leave it here.
741751
-->
742752

753+
> Note: To be elaborated more during Beta graduation since this section
754+
must be completed when targeting beta to a release.
755+
743756
###### How does this feature react if the API server and/or etcd is unavailable?
744757

745758
No effect.

0 commit comments

Comments
 (0)