Skip to content

Commit a52b063

Browse files
committed
address peter comments
1 parent d39991e commit a52b063

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

keps/sig-node/2400-node-swap/README.md

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -228,9 +228,9 @@ The main concern would be swapping in the critical services on the control plane
228228

229229
##### Use of a dedicated disk for swap
230230

231-
We recommend using a separate disk for your swap partition. With [encryption](#security-risk), an encrypted disk is recommended for swap.
231+
We recommend using a separate disk for your swap partition. We recommend the separate disk be [encrypted](#security-risk).
232232
If swap is on a partition or the root filesystem, workloads can interfere with system processes needing to write to disk.
233-
If they occupy the same disk, it's possible processes can overwhelm swap and throw off the I/O of kubelet/cri-o/systemd, which would affect other workloads
233+
If they occupy the same disk, it's possible processes can overwhelm swap and throw off the I/O of kubelet/container runtime/systemd, which would affect other workloads
234234

235235
##### Swap as the default
236236

@@ -332,9 +332,6 @@ clusters).
332332

333333
This user story is addressed by scenarios 1 and 2, and could benefit from 3.
334334

335-
It turns out that we discovered usecases where someone areas set `--fail-swap-on=false`
336-
to allow for swap enabled nodes for local development.
337-
338335
#### Low footprint systems
339336

340337
For example, edge devices with limited memory.

0 commit comments

Comments
 (0)