Skip to content

Commit aa3d634

Browse files
Clarify that the order of enabling/disabling the feature-gate doesn't
matter. Signed-off-by: Vinayak Goyal <[email protected]>
1 parent 1a1dc0f commit aa3d634

File tree

1 file changed

+10
-0
lines changed
  • keps/sig-node/2862-fine-grained-kubelet-authz

1 file changed

+10
-0
lines changed

keps/sig-node/2862-fine-grained-kubelet-authz/README.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -731,6 +731,12 @@ NOTE: Also set `disable-supported` to `true` or `false` in `kep.yaml`.
731731
Yes, but a workload that is only authorized to use the new authorization subresource
732732
will lose access and will need to update its RBAC Role to use `nodes/proxy`.
733733

734+
Having the feature-gate enabled in kubelet and disabled in kube-apiserver or
735+
vice versa will not impact kube-apiserver's ability to talk to the kubelet API.
736+
This is because whether the feature-gate is enabled or disabled kube-apiserver
737+
will always have `nodes/proxy` permissions in it's RBAC. So either the first or
738+
the second SubjectAccessReview request will authorize kube-apiserver.
739+
734740
###### What happens if we reenable the feature if it was previously rolled back?
735741

736742
If the kubelet feature-gate is re-enabled then kubelet will again start sending
@@ -739,6 +745,10 @@ If the kubelet feature-gate is re-enabled then kubelet will again start sending
739745
If the kube-apiserver feature-gate is re-enabled then the ClusterRole `system:kubelet-api-admin`
740746
will be updated as described in the (Design Details section)[#design-details].
741747

748+
Readers might wonder if the order in which the feature-gate is disabled matters?
749+
It does not because no matter what the state kube-apiserver will always have `nodes/proxy`
750+
permissions in it's RBAC.
751+
742752
###### Are there any tests for feature enablement/disablement?
743753

744754
<!--

0 commit comments

Comments
 (0)