Skip to content

Commit ad40779

Browse files
authored
Merge pull request #4226 from aramase/aramase/f/kms_kep_ga_update
KMSv2: Update KEP for GA
2 parents 0a6d6c8 + 2195255 commit ad40779

File tree

3 files changed

+12
-1
lines changed

3 files changed

+12
-1
lines changed

keps/prod-readiness/sig-auth/3299.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,5 @@ alpha:
33
approver: "@deads2k"
44
beta:
55
approver: "@deads2k"
6+
stable:
7+
approver: "@deads2k"

keps/sig-auth/3299-kms-v2-improvements/README.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -539,6 +539,15 @@ FeatureSpec{
539539
}
540540
```
541541

542+
**GA**
543+
```go
544+
FeatureSpec{
545+
Default: true,
546+
LockToDefault: true,
547+
PreRelease: featuregate.GA,
548+
}
549+
```
550+
542551
###### Does enabling the feature change any default behavior?
543552

544553
No. The v2 API is new in the v1.25 release. Furthermore, even with the feature enabled by default, the user needs to explicitly configure a KMSv2 provider to use this.

keps/sig-auth/3299-kms-v2-improvements/kep.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ approvers:
1515
replaces:
1616
- "/keps/sig-auth/3130-kms-observability"
1717
stage: beta
18-
latest-milestone: "v1.28"
18+
latest-milestone: "v1.29"
1919
# The milestone at which this feature was, or is targeted to be, at each stage.
2020
milestone:
2121
alpha: "v1.25"

0 commit comments

Comments
 (0)