You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@@ -108,7 +108,7 @@ As part of this proposal, we are mainly proposing three changes:
108
108
- NodeExpansionFailed // state set when expansion has failed in kubelet with a terminal error. Transient errors don't set NodeExpansionFailed.
109
109
3. Update quota code to use `max(pvc.Spec.Resources, pvc.Status.AllocatedResources)` when evaluating usage for PVC.
110
110
111
-
### Making resizeStatus more general
111
+
### Making resizeStatus more general in v1.27
112
112
113
113
After some discussion with sig-storage folks and to accommodate changes coming from https://github.com/kubernetes/enhancements/issues/3751 we are proposing that we rename `pvc.Status.ResizeStatus` to `pvc.Status.AllocatedResourceStatus` and make it a map.
// PersistentVolumeClaimStatus represents the status of PV claim
@@ -302,7 +302,7 @@ The complete expansion and recovery flow of both control-plane and kubelet is do
302
302
so it should not break any of existing automation. This means that if `pvc.Status.AllocatedResources` is available it will be
303
303
used for calculating quota.
304
304
305
-
To facilitate older kubelet - external resize controller will set `pvc.Status.ResizeStatus` to "''" after entire expansion process is complete. This will ensure that `ResizeStatus` is updated
305
+
To facilitate older kubelet - external resize controller will set `pvc.Status.AllocatedResourceStatus[storage]` to "''" after entire expansion process is complete. This will ensure that `ResizeStatus` is updated
306
306
after expansion is complete even with older kubelet. No recovery from expansion failure will be possible in this case and the workaround will be removed once feature goes GA.
307
307
308
308
One more thing to keep in mind is - enabling this feature in kubelet while keeping it disabled in external-resizer will cause
@@ -447,15 +447,15 @@ _This section must be completed when targeting beta graduation to a release._
447
447
***What are other known failure modes?**
448
448
For each of them fill in the following information by copying the below template:
449
449
- No recovery is possible if volume has been expanded on control-plane and only failing on node.
450
-
- Detection: Expansion is stuck with `ResizeStatus` - `NodeResizePending` or `NodeResizeFailed`.
450
+
- Detection: Expansion is stuck with `AllocatedResourceStatus[storage]` - `NodeResizePending` or `NodeResizeFailed`.
451
451
- Mitigations: This should not affect any of existing PVCs but this was already broken in some sense and if volume has been
452
452
expanded in control-plane then we can't allow users to shrink their PVCs because that would violate the quota.
453
-
- Diagnostics: Expansion is stuck with `ResizeStatus` - `NodeResizePending` or `NodeResizeFailed`.
453
+
- Diagnostics: Expansion is stuck with `AllocatedResourceStatus['storage']` - `NodeResizePending` or `NodeResizeFailed`.
454
454
- Testing: There are some unit tests for this failure mode.
455
455
456
456
***What steps should be taken if SLOs are not being met to determine the problem?**
457
457
If admin notices an increase in expansion failure operations via aformentioned metrics or
458
-
by observing `pvc.Status.ResizeStatus` then:
458
+
by observing `pvc.Status.AllocatedResourceStatus['storage']` then:
459
459
- Check events on the PVC and observe why is PVC expansion failing.
460
460
- Gather logs from kubelet and external-resizer and check for problems.
461
461
@@ -466,6 +466,7 @@ _This section must be completed when targeting beta graduation to a release._
466
466
## Implementation History
467
467
468
468
- 2020-01-27 Initial KEP pull request submitted
469
+
- 2023-02-03 Changing the APIs of `pvc.Status.ResizeStatus` by renaming it to `pvc.Status.AllocatedResourceStatus` and converting it to a map.
0 commit comments