Skip to content

Commit b69cbc4

Browse files
committed
Fix review comments
1 parent 01919b4 commit b69cbc4

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

keps/prod-readiness/sig-network/1860.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,5 @@
44
kep-number: 1860
55
alpha:
66
approver: "@wojtek-t"
7+
beta:
8+
approver: "@wojtek-t" # temptative

keps/sig-network/1860-kube-proxy-IP-node-binding/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -233,8 +233,8 @@ Checking if the field `.status.loadBalancer.ingress.ipMode` is set to `Proxy`
233233

234234
###### What are the reasonable SLOs (Service Level Objectives) for the enhancement?
235235

236-
No increase of error rate when a workload of a cluster is targeting a service of
237-
type LoadBalancer and the feature enabled.
236+
The quality of service for clouds using this feature is the same as the existing
237+
quality of service for clouds that don't need this feature
238238

239239
###### What are the SLIs (Service Level Indicators) an operator can use to determine the health of the service?
240240

keps/sig-network/1860-kube-proxy-IP-node-binding/kep.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ approvers:
1414
- "@thockin"
1515
- "@andrewsykim"
1616

17-
stage: "alpha"
17+
stage: "beta"
1818

19-
latest-milestone: "v1.29"
19+
latest-milestone: "v1.30"
2020

2121
milestone:
2222
alpha: "v1.29"

0 commit comments

Comments
 (0)