@@ -290,7 +290,7 @@ will not be able to start. This can be mitigated by fixing the malformed values.
290
290
We would like to introduce a structured file format which allows authorization
291
291
to be configured using a flag (`--authorization-config-file`) which accepts a
292
292
path to a file on the disk. Setting both `--authorization-config-file` and
293
- configuring an authorization webhook using the `--authorization-webhook-*`
293
+ configuring an authorization webhook using the `--authorization-webhook-*`
294
294
command line flags will not be allowed. If the user does that,
295
295
there will be an error and API Server would exit right away.
296
296
@@ -301,7 +301,7 @@ The API server will periodically reload the configuration. If it changes, the
301
301
new configuration will be used for the Authorizer chain. If the new configuration
302
302
is invalid, the last known valid configuration will be used. Logging and metrics
303
303
would be used to signal success/failure of a config reload so that cluster admins
304
- can have observability over this process. Reload must not add or remove Node or RBAC
304
+ can have observability over this process. Reload must not add or remove Node or RBAC
305
305
authorizers. They can be reordered, but cannot be added or removed.
306
306
307
307
The proposed structure is illustrated below :
@@ -420,21 +420,21 @@ to the authz webhook for which the expression has been defined. The user would h
420
420
to a `request` variable containing a `SubjectAccessReview` object in the version specified
421
421
by `subjectAccessReviewVersion`.
422
422
423
- The code path for enabling the above will only be triggered if the feature flag is enabled until
423
+ The code path for enabling the above will only be triggered if the feature flag is enabled until
424
424
the feature flag is removed and this feature graduates to GA.
425
425
426
426
# ## Monitoring
427
427
428
428
We will add the following 4 metrics :
429
429
430
- 1. `apiserver_authorization_step_invocations_total `
430
+ 1. `apiserver_authorization_decisions_total `
431
431
432
432
This will be incremented on round-trip of an authorizer. It will track total
433
433
authorization decision invocations across the following labels.
434
434
435
435
Labels {along with possible values} :
436
436
- ` mode` {<authorizer_name>}
437
- - ` decision` {Allow, Deny, NoOpinion }
437
+ - ` decision` {Allow, Deny}
438
438
439
439
**Note:** Some examples of <authorizer_name>: `RBAC`, `Node`, `ABAC`, `webhook{,_<name>}`.
440
440
If there is only one webhook, there would be no `_<name>` suffix.
@@ -500,7 +500,7 @@ We should benchmark the cost of some common CEL expressions inside
500
500
# #### Integration tests
501
501
502
502
Integration tests would be added to ensure the following :
503
- - Authorization of requests work in the existing command line flag
503
+ - Authorization of requests work in the existing command line flag
504
504
based mode (feature flag turned off)
505
505
- Authorization of requests work with an apiserver bootstrapped with
506
506
authorization configuration file (feature flag turned on)
0 commit comments