Skip to content

Commit bd077a3

Browse files
committed
fixup! KEP-3221: update kep
Signed-off-by: Nabarun Pal <[email protected]>
1 parent 921267e commit bd077a3

File tree

1 file changed

+6
-6
lines changed
  • keps/sig-auth/3221-structured-authorization-configuration

1 file changed

+6
-6
lines changed

keps/sig-auth/3221-structured-authorization-configuration/README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ will not be able to start. This can be mitigated by fixing the malformed values.
290290
We would like to introduce a structured file format which allows authorization
291291
to be configured using a flag (`--authorization-config-file`) which accepts a
292292
path to a file on the disk. Setting both `--authorization-config-file` and
293-
configuring an authorization webhook using the `--authorization-webhook-*`
293+
configuring an authorization webhook using the `--authorization-webhook-*`
294294
command line flags will not be allowed. If the user does that,
295295
there will be an error and API Server would exit right away.
296296

@@ -301,7 +301,7 @@ The API server will periodically reload the configuration. If it changes, the
301301
new configuration will be used for the Authorizer chain. If the new configuration
302302
is invalid, the last known valid configuration will be used. Logging and metrics
303303
would be used to signal success/failure of a config reload so that cluster admins
304-
can have observability over this process. Reload must not add or remove Node or RBAC
304+
can have observability over this process. Reload must not add or remove Node or RBAC
305305
authorizers. They can be reordered, but cannot be added or removed.
306306

307307
The proposed structure is illustrated below:
@@ -420,21 +420,21 @@ to the authz webhook for which the expression has been defined. The user would h
420420
to a `request` variable containing a `SubjectAccessReview` object in the version specified
421421
by `subjectAccessReviewVersion`.
422422

423-
The code path for enabling the above will only be triggered if the feature flag is enabled until
423+
The code path for enabling the above will only be triggered if the feature flag is enabled until
424424
the feature flag is removed and this feature graduates to GA.
425425

426426
### Monitoring
427427

428428
We will add the following 4 metrics:
429429

430-
1. `apiserver_authorization_step_invocations_total`
430+
1. `apiserver_authorization_decisions_total`
431431

432432
This will be incremented on round-trip of an authorizer. It will track total
433433
authorization decision invocations across the following labels.
434434

435435
Labels {along with possible values}:
436436
- `mode` {<authorizer_name>}
437-
- `decision` {Allow, Deny, NoOpinion}
437+
- `decision` {Allow, Deny}
438438

439439
**Note:** Some examples of <authorizer_name>: `RBAC`, `Node`, `ABAC`, `webhook{,_<name>}`.
440440
If there is only one webhook, there would be no `_<name>` suffix.
@@ -500,7 +500,7 @@ We should benchmark the cost of some common CEL expressions inside
500500
##### Integration tests
501501

502502
Integration tests would be added to ensure the following:
503-
- Authorization of requests work in the existing command line flag
503+
- Authorization of requests work in the existing command line flag
504504
based mode (feature flag turned off)
505505
- Authorization of requests work with an apiserver bootstrapped with
506506
authorization configuration file (feature flag turned on)

0 commit comments

Comments
 (0)