Skip to content

Commit bd97a39

Browse files
MadhavJivrajanisoltysh
authored andcommitted
sig-cli: graduate kubectl subresource support to GA
Signed-off-by: Madhav Jivrajani <[email protected]>
1 parent 9f7ee23 commit bd97a39

File tree

3 files changed

+30
-5
lines changed

3 files changed

+30
-5
lines changed

keps/prod-readiness/sig-cli/2590.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,6 @@ kep-number: 2590
22
alpha:
33
approver: "@johnbelamaric"
44
beta:
5+
approver: "@johnbelamaric"
6+
stable:
57
approver: "@johnbelamaric"

keps/sig-cli/2590-kubectl-subresource/README.md

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,10 @@ to implement this enhancement.
220220

221221
##### e2e tests
222222

223+
- e2e test added:
224+
- [Link to testgrid](https://testgrid.k8s.io/sig-testing-canaries#ci-kubernetes-coverage-e2e-gci-gce&include-filter-by-regex=kubectl%20subresource)
225+
- [Link to test](https://github.com/kubernetes/kubernetes/blob/11b974043604f5ccbeb6e5e62e1d9edcf00bc336/test/e2e/kubectl/kubectl.go#L2101)
226+
223227
### Graduation Criteria
224228

225229
#### Alpha
@@ -234,7 +238,11 @@ to implement this enhancement.
234238

235239
#### GA
236240

237-
- User feedback gathered for at least 1 cycle.
241+
Since v1.27 when the feature moved to beta, there have been no reported bugs concerning this feature.
242+
In fact, it is reassuring to see the community use this feature quite commonly such as in bug reports:
243+
https://github.com/kubernetes/kubernetes/issues/116311
244+
245+
Seeing this and given our added unit, integration and e2e tests gives us the confidence to graduate to GA.
238246

239247

240248
### Upgrade / Downgrade Strategy
@@ -332,10 +340,17 @@ No.
332340

333341
### Monitoring Requirements
334342

343+
Considering that this feature is a flag contained fully within in the `kubectl` client, there exist no
344+
monitoring requirements for the same.
345+
335346
###### How can an operator determine if the feature is in use by workloads?
336347

337348
N/A
338349

350+
###### How can someone using this feature know that it is working for their instance?
351+
352+
N/A
353+
339354
###### What are the SLIs (Service Level Indicators) an operator can use to determine the health of the service?
340355

341356
N/A
@@ -388,6 +403,10 @@ No
388403

389404
No
390405

406+
###### Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)?
407+
408+
No
409+
391410
### Troubleshooting
392411

393412
###### How does this feature react if the API server and/or etcd is unavailable?
@@ -408,6 +427,9 @@ N/A
408427
2021-04-06: KEP proposed
409428
2021-04-07: [Demo] in SIG CLI meeting
410429
2022-05-25: PR for alpha implementation merged
430+
2023-01-12: KEP graduated to Beta
431+
2023-03-15: e2e test added for KEP as part of beta graduation
432+
2024-02-01: KEP graduated to Stable
411433

412434
[POC PR]: https://github.com/kubernetes/kubernetes/pull/99556
413435
[Demo]: https://youtu.be/zUa7dudYCQM?t=299

keps/sig-cli/2590-kubectl-subresource/kep.yaml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,14 @@ approvers:
1212
- "@soltysh"
1313

1414
creation-date: 2021-04-06
15-
last-updated: 2023-01-12
15+
last-updated: 2024-02-01
1616

17-
status: implementable
18-
stage: beta
17+
status: implemented
18+
stage: stable
1919

20-
latest-milestone: "v1.27"
20+
latest-milestone: "v1.30"
2121

2222
milestone:
2323
alpha: "v1.24"
2424
beta: "v1.27"
25+
stable: "v1.30"

0 commit comments

Comments
 (0)